patch "iio: ensure ret is initialized to zero before entering do loop" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: ensure ret is initialized to zero before entering do loop
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
5dba4b14bafe801083d01e1f400816df7e5a8f2eMon Sep 17 00:00:00 2001
From: Colin Ian King <[email protected]>
Date: Mon, 5 Sep 2016 15:39:06 +0100
Subject: iio: ensure ret is initialized to zero before entering do loop
A recent fix to iio_buffer_read_first_n_outer removed ret from being set by a return from wait_event_interruptible and also added a continue in a loop which causes the variable ret to not be set when it reaches the end of the loop. Fix this by initializing ret to zero.
Also remove extraneous white space at the end of the loop.
--- drivers/iio/industrialio-buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/industrialio-buffer.c +2 -2
@@ -110,7 +110,7 @@ ssize_t iio_buffer_read_first_n_outer(struct file *filp, char __user *buf,DEFINE_WAIT_FUNC (wait, woken_wake_function);size_t datum_size;size_t to_wait; -int ret; +int ret =0 ;if (!indio_dev->info)return -ENODEV ;
@@ -153,7 +153,7 @@ ssize_t iio_buffer_read_first_n_outer(struct file *filp, char __user *buf, ret = rb->access->read_first_n (rb, n, buf);if (ret ==0 && (filp->f_flags &O_NONBLOCK )) ret = -EAGAIN ; - }while (ret ==0 ); + }while (ret ==0 );remove_wait_queue (&rb->pollq, &wait);return ret;
Signature · 1 line
2.9.3