Patch "[PATCH 056/135] lpfc: Fix mbox reuse in PLOGI completion" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
[PATCH 056/135] lpfc: Fix mbox reuse in PLOGI completion
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
0056-lpfc-Fix-mbox-reuse-in-PLOGI-completion.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f67fd277e0e1e9b57bf42dc1a56a10b82ee3a5f2Mon Sep 17 00:00:00 2001
From: James Smart <[email protected]>
Date: Wed, 16 Dec 2015 18:12:03 -0500
Subject: [PATCH 056/135] lpfc: Fix mbox reuse in PLOGI completion
[ Upstream commit 01c73bbcd7cc4f31f45a1b0caeacdba46acd9c9c ]
Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd.
--- drivers/scsi/lpfc/lpfc_nportdisc.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-)
drivers/scsi/lpfc/lpfc_nportdisc.c +21 -10
@@ -1045,16 +1045,6 @@ lpfc_cmpl_plogi_plogi_issue(struct lpfc_if (irsp->ulpStatus) goto out; - mbox =mempool_alloc (phba->mbox_mem_pool,GFP_KERNEL ); -if (!mbox) { -lpfc_printf_vlog (vport,KERN_ERR ,LOG_ELS , -"0133 PLOGI: no memory for reg_login " -"Data: x%x x%x x%x x%x\n" , - ndlp->nlp_DID, ndlp->nlp_state, - ndlp->nlp_flag, ndlp->nlp_rpi); - goto out; - } - pcmd = (struct lpfc_dmabuf *) cmdiocb->context2; prsp = list_get_first(&pcmd->list, struct lpfc_dmabuf, list);
@@ -1118,6 +1108,17 @@ lpfc_cmpl_plogi_plogi_issue(struct lpfc_if (phba->sli_rev ==LPFC_SLI_REV4 ) {lpfc_issue_reg_vfi (vport); }else { + mbox =mempool_alloc (phba->mbox_mem_pool,GFP_KERNEL ); +if (!mbox) { +lpfc_printf_vlog (vport,KERN_ERR ,LOG_ELS , +"0133 PLOGI: no memory " +"for config_link " +"Data: x%x x%x x%x x%x\n" , + ndlp->nlp_DID, ndlp->nlp_state, + ndlp->nlp_flag, ndlp->nlp_rpi); + goto out; + } +lpfc_config_link (phba, mbox); mbox->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
@@ -1132,6 +1133,16 @@ lpfc_cmpl_plogi_plogi_issue(struct lpfc_lpfc_unreg_rpi (vport, ndlp); + mbox =mempool_alloc (phba->mbox_mem_pool,GFP_KERNEL ); +if (!mbox) { +lpfc_printf_vlog (vport,KERN_ERR ,LOG_ELS , +"0018 PLOGI: no memory for reg_login " +"Data: x%x x%x x%x x%x\n" , + ndlp->nlp_DID, ndlp->nlp_state, + ndlp->nlp_flag, ndlp->nlp_rpi); + goto out; + } +if (lpfc_reg_rpi (phba, vport->vpi, irsp->un.elsreq64.remoteID, (uint8_t *) sp, mbox, ndlp->nlp_rpi) ==0 ) {switch (ndlp->nlp_DID) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0056-lpfc-Fix-mbox-reuse-in-PLOGI-completion.patch queue-4.4/0052-lpfc-Fix-driver-crash-when-module-parameter-lpfc_fcp.patch queue-4.4/0121-lpfc-Fix-DMA-faults-observed-upon-plugging-loopback-.patch queue-4.4/0049-lpfc-Fix-FCF-Infinite-loop-in-lpfc_sli4_fcf_rr_next_.patch queue-4.4/0055-lpfc-Fix-RDP-ACC-being-too-long.patch queue-4.4/0051-lpfc-Fix-RegLogin-failed-error-seen-on-Lancer-FC-dur.patch queue-4.4/0054-lpfc-Fix-RDP-Speed-reporting.patch queue-4.4/0057-lpfc-Fix-external-loopback-failure.patch queue-4.4/0053-lpfc-Fix-crash-in-fcp-command-completion-path.patch queue-4.4/0050-lpfc-Fix-the-FLOGI-discovery-logic-to-comply-with-T1.patch