Skip to contentSkip to conversation

Patch "[PATCH 086/135] tipc: fix nullptr crash during subscription cancel" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 9, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[PATCH 086/135] tipc: fix nullptr crash during subscription cancel

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
0086-tipc-fix-nullptr-crash-during-subscription-cancel.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 581919f8939f278d7553e3ec38470f13a2b34235 Mon Sep 17 00:00:00 2001

From: Parthasarathy Bhuvaragan <[email protected]>
Date: Thu, 3 Mar 2016 17:54:54 +0100
Subject: [PATCH 086/135] tipc: fix nullptr crash during subscription cancel

[ Upstream commit 4de13d7ed6ffdcbb34317acaa9236f121176f5f8 ]

commit 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel'), removes the check for a valid subscription before calling tipc_nametbl_subscribe().

This will lead to a nullptr exception when we process a subscription cancel request. For a cancel request, a null subscription is passed to tipc_nametbl_subscribe() resulting in exception.

In this commit, we call tipc_nametbl_subscribe() only for a valid subscription.

Fixes 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel')
---
 net/tipc/subscr.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/tipc/subscr.c +2 -1
@@ -296,7 +296,8 @@ static void tipc_subscrb_rcv_cb(struct n
 	if (tipc_subscrp_create(net, (struct tipc_subscr *)buf, subscrb, &sub))
 		return tipc_conn_terminate(tn->topsrv, subscrb->conid);
 
-	tipc_nametbl_subscribe(sub);
+	if (sub)
+		tipc_nametbl_subscribe(sub);
 }
 
 /* Handle one request to establish a new subscriber */

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/0086-tipc-fix-nullptr-crash-during-subscription-cancel.patch