Skip to contentSkip to conversation

Patch "drm/vc4: Fix oops when userspace hands in a bad BO." has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 9, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/vc4: Fix oops when userspace hands in a bad BO.

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-vc4-fix-oops-when-userspace-hands-in-a-bad-bo.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 552416c146fadc67cd9b53ef7adf88d3381c43a6 Mon Sep 17 00:00:00 2001

From: Eric Anholt <[email protected]>
Date: Tue, 26 Jul 2016 13:47:15 -0700
Subject: drm/vc4: Fix oops when userspace hands in a bad BO.

From: Eric Anholt <[email protected]>

commit 552416c146fadc67cd9b53ef7adf88d3381c43a6 upstream.

We'd end up NULL pointer dereferencing because we didn't take the error path out in the parent. Fixes igt vc4_lookup_fail test.

Fixes d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
---
 drivers/gpu/drm/vc4/vc4_gem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_gem.c +1 -1
@@ -575,7 +575,7 @@ vc4_cl_lookup_bos(struct drm_device *dev
 
 fail:
 	drm_free_large(handles);
-	return 0;
+	return ret;
 }
 
 static int

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/drm-vc4-fix-oops-when-userspace-hands-in-a-bad-bo.patch queue-4.7/drm-vc4-use-drm_free_large-on-handles-to-match-its-allocation.patch queue-4.7/drm-vc4-fix-overflow-mem-unreferencing-when-the-binner-runs-dry.patch