Skip to contentSkip to conversation

Updating MAINTAINERS and Documentation/video4linux F: patterns

DISCUSSION Joe Perches 3 participants 4 messages Sep 9, 2016 – Sep 13, 2016

lore
Share & tools
lore
#0 lore raw

Hello Mauro.

After all the moving of video4linux Documentation file locations around and converting .txt files to .rst, can you please update the appropriate MAINTAINERS sections and F: patterns?

Thanks.

#1 lore raw
Quoted 3 lines · Joe Perches

After all the moving of video4linux Documentation file locations around and converting .txt files to .rst, can you please update the appropriate MAINTAINERS sections and F: patterns?

Hmm, for patches doing rename/create/delete, checkpatch could look at MAINTAINERS and remind the user if a MAINTAINERS update is needed.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#2 lore raw

Em Tue, 13 Sep 2016 12:22:51 +0300
Jani Nikula <[email protected]> escreveu:

Quoted 7 lines · Joe Perches
Quoted 3 lines

After all the moving of video4linux Documentation file locations around and converting .txt files to .rst, can you please update the appropriate MAINTAINERS sections and F: patterns?

Hmm, for patches doing rename/create/delete, checkpatch could look at MAINTAINERS and remind the user if a MAINTAINERS update is needed.

Good point. Checkpatch does that already, as I remember from time to time I receive such warnings when a new driver is created, renamed or removed. I didn't notice it on my patchset though.

Perhaps it excludes Documentation/ from the check logic.

Regards,
Mauro

PS.: In the specific case of media docs, I submitted a patch yesterday addressing those renames.

#3 lore raw
In reply to Jani Nikula
Quoted 7 lines · Jani Nikula
Quoted 1 line · Joe Perches

After all the moving of video4linux Documentation file locations around and converting .txt files to .rst, can you please update the appropriate MAINTAINERS sections and F: patterns?

Hmm, for patches doing rename/create/delete, checkpatch could look at MAINTAINERS and remind the user if a MAINTAINERS update is needed.

Thanks, checkpatch already does exactly that.

$ ./scripts/checkpatch.pl -git 43efd1edc63534d3a7486a0548c8aedf8b1128d1
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#86: 
deleted file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 43efd1edc635 ("[media] get rid of Documentation/video4linux/lifeview.txt") has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

or another way:

$ git log --stat -p  --format=email -1 -M 43efd1edc63534d3a7486a0548c8aedf8b1128d1 | ./scripts/checkpatch.pl -
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
deleted file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

Quoted 1 line