Skip to contentSkip to conversation

: Fix error handling in max17042 fuel gauge

PATCH MyungJoo Ham 2 participants 4 messages Sep 7, 2011 – Sep 15, 2011

lore
Share & tools
lore
#0 lore raw

Sender : Pallala, Ramakrishna<[email protected]> Date : 2011-09-07 17:30 (GMT+09:00)

Quoted 25 lines

Hi MyungJoo,

Quoted 23 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Monday, September 05, 2011 6:55 AM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

Sender : Ramakrishna Pallala<[email protected]> Date : 2011-09-02 15:45 (GMT+09:00)

Quoted 13 lines

In max17042_get_property(...), the values returned by max17042_read_reg are directly assigned to the variables, even if the read results in an error.

This patch checks for the return code from max17042_read_reg and exits the function if there is any error.

Signed-off-by Ramakrishna Pallala

---
drivers/power/max17042_battery.c | 85 ++++++++++++++++++++++++++------------

1 files changed, 58 insertions(+), 27 deletions(-)
Quoted 8 lines
Quoted 1 line

Thanks for the Ack.
When can I expect the patch to be merged ?

Thanks,
Ram

Hello Ram,

Although I'd be so glad to be able to merge patches of MAX17042 (and MAX8997/8998/8952/8903/...?) by myself; however, I'm not a maintainer of MAX17042.

I guess you need to wait for Anton.

Cheers,
MyungJoo

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw

Hi Anton,

Quoted 45 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Wednesday, September 07, 2011 2:17 PM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

Sender : Pallala, Ramakrishna<[email protected]> Date : 2011-09-07 17:30 (GMT+09:00)

Quoted 25 lines

Hi MyungJoo,

Quoted 23 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Monday, September 05, 2011 6:55 AM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

Sender : Ramakrishna Pallala<[email protected]> Date : 2011-09-02 15:45 (GMT+09:00)

Quoted 13 lines

In max17042_get_property(...), the values returned by max17042_read_reg are directly assigned to the variables, even if the read results in an error.

This patch checks for the return code from max17042_read_reg and exits the function if there is any error.

Signed-off-by Ramakrishna Pallala

---
drivers/power/max17042_battery.c | 85 ++++++++++++++++++++++++++------------

1 files changed, 58 insertions(+), 27 deletions(-)
Quoted 8 lines
Quoted 1 line

Thanks for the Ack.
When can I expect the patch to be merged ?

Thanks,
Ram

Hello Ram,

Quoted 7 lines

Although I'd be so glad to be able to merge patches of MAX17042 (and MAX8997/8998/8952/8903/...?) by myself; however, I'm not a maintainer of MAX17042.

I guess you need to wait for Anton.

Cheers,
MyungJoo

When can I expect the patch to be merged ?

Thanks,
Ram �淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#2 lore raw
In reply to MyungJoo Ham

Hi Anton,

Quoted 62 lines

-----Original Message-----
From: Pallala, Ramakrishna
Sent: Thursday, September 08, 2011 11:07 PM
To: [email protected]; [email protected]; Anton Vorontsov
Cc: [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: RE: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

Hi Anton,

Quoted 6 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Wednesday, September 07, 2011 2:17 PM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel

gauge

Quoted 11 lines

Sender : Pallala, Ramakrishna<[email protected]> Date : 2011-09-07 17:30 (GMT+09:00)

Quoted 8 lines

Hi MyungJoo,

Quoted 6 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Monday, September 05, 2011 6:55 AM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel

gauge

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Sender : Ramakrishna Pallala<[email protected]> Date : 2011-09-02

15:45

Quoted 31 lines
Quoted 15 lines
Quoted 15 lines

(GMT+09:00)

Quoted 13 lines

In max17042_get_property(...), the values returned by max17042_read_reg are directly assigned to the variables, even if the read results in an error.

This patch checks for the return code from max17042_read_reg and exits the function if there is any error.

Signed-off-by Ramakrishna Pallala

---
drivers/power/max17042_battery.c | 85 ++++++++++++++++++++++++++------------

1 files changed, 58 insertions(+), 27 deletions(-)
Quoted 8 lines
Quoted 1 line

Thanks for the Ack.
When can I expect the patch to be merged ?

Thanks,
Ram

Hello Ram,

Although I'd be so glad to be able to merge patches of MAX17042 (and MAX8997/8998/8952/8903/...?) by myself; however, I'm not a maintainer of MAX17042.

I guess you need to wait for Anton.

Quoted 7 lines
Quoted 2 lines

Cheers,
MyungJoo

When can I expect the patch to be merged ?

Thanks,
Ram

Please let me know your feedback on this patch.

Thanks,
Ram �淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#3 lore raw

Hi Anton/Sang/David,

Quoted 78 lines

-----Original Message-----
From: Pallala, Ramakrishna
Sent: Monday, September 12, 2011 6:18 PM
To: Pallala, Ramakrishna; [email protected]; [email protected]; Anton Vorontsov; [email protected]
Cc: [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: RE: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge

Hi Anton,

Quoted 6 lines

-----Original Message-----
From: Pallala, Ramakrishna
Sent: Thursday, September 08, 2011 11:07 PM
To: [email protected]; [email protected]; Anton Vorontsov
Cc: [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: RE: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel

gauge

Quoted 61 lines

Hi Anton,

Quoted 6 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Wednesday, September 07, 2011 2:17 PM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel

gauge

Quoted 11 lines

Sender : Pallala, Ramakrishna<[email protected]> Date : 2011-09-07 17:30 (GMT+09:00)

Quoted 8 lines

Hi MyungJoo,

Quoted 6 lines

-----Original Message-----
From: MyungJoo Ham [mailto:[email protected]]
Sent: Monday, September 05, 2011 6:55 AM
To: Pallala, Ramakrishna; [email protected]
Cc: Anton Vorontsov; [email protected]; 박경민; Wolfram Sang; R, Durgadoss
Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel

gauge

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Sender : Ramakrishna Pallala<[email protected]> Date : 2011-09-02

15:45

Quoted 26 lines
Quoted 15 lines
Quoted 15 lines

(GMT+09:00)

Quoted 13 lines

In max17042_get_property(...), the values returned by max17042_read_reg are directly assigned to the variables, even if the read results in an error.

This patch checks for the return code from max17042_read_reg and exits the function if there is any error.

Signed-off-by Ramakrishna Pallala

---
drivers/power/max17042_battery.c | 85 ++++++++++++++++++++++++++------------

1 files changed, 58 insertions(+), 27 deletions(-)
Quoted 8 lines
Quoted 1 line

Thanks for the Ack.
When can I expect the patch to be merged ?

Thanks,
Ram

Hello Ram,

Quoted 7 lines

Although I'd be so glad to be able to merge patches of MAX17042 (and MAX8997/8998/8952/8903/...?) by myself; however, I'm not a maintainer of MAX17042.

I guess you need to wait for Anton.

Cheers,
MyungJoo

When can I expect the patch to be merged ?

Quoted 7 lines
Quoted 2 lines

Thanks,
Ram

Please let me know your feedback on this patch.

Thanks,
Ram

I have been waiting for your comments for two weeks. Please let me know when can I get the feedback on this patch.

Thanks,
Ram �淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�