x264: add textrel to INSANE_SKIP for cyclone5 machine
PATCH 1/1 x264: add textrel to INSANE_SKIP for cyclone5 machine
From: Fahad Usman <[email protected]>
This change help fix the warning message:
x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel]
Adding textrel to INSANE_SKIP resolves this issue.
--- meta/recipes-multimedia/x264/x264_git.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/x264/x264_git.bb +2 -1
@@ -48,6 +48,7 @@ do_install() { oe_runmake install DESTDIR=${D} } -# PIC can't be enabled for 32-bit x86 +# PIC can't be enabled for 32-bit x86 and cyclone5 INSANE_SKIP_${PN}_append_x86 = " textrel" +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
Signature · 1 line
1.9.1
meta/recipes-multimedia/x264/x264_git.bb do_install() { · line 53
Quoted 4 lines · Sujith H
meta/recipes-multimedia/x264/x264_git.bb +2
-0+# PIC can't be enabled for 32-bit x86 and cyclone5 INSANE_SKIP_${PN}_append_x86 = " textrel" +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
Can this be generalised or is it absolutely specific to cyclone5? If it can't be generalised then I feel that this should belong in the cyclone5 BSP.
Ross
Quoted 12 lines · Ross
meta/recipes-multimedia/x264/x264_git.bb do_install() { · line 53
Quoted 4 lines · Sujith H
meta/recipes-multimedia/x264/x264_git.bb +2
-0+# PIC can't be enabled for 32-bit x86 and cyclone5 INSANE_SKIP_${PN}_append_x86 = " textrel" +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"Can this be generalised or is it absolutely specific to cyclone5? If it can't be generalised then I feel that this should belong in the cyclone5 BSP.
We found this with cyclone5 BSP. I will try to figure out how if we can see it with qemuarm or other BSP's too.
Quoted 3 lines
Ross
Signature · 7 lines
സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c
Quoted 18 lines · sujith h
Quoted 12 lines · Ross
meta/recipes-multimedia/x264/x264_git.bb do_install() { · line 53
Quoted 4 lines · Sujith H
meta/recipes-multimedia/x264/x264_git.bb +2
-0+# PIC can't be enabled for 32-bit x86 and cyclone5 INSANE_SKIP_${PN}_append_x86 = " textrel" +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"Can this be generalised or is it absolutely specific to cyclone5? If it can't be generalised then I feel that this should belong in the cyclone5 BSP.
Quoted 3 lines
We found this with cyclone5 BSP. I will try to figure out how if we can see it with qemuarm or other BSP's too.
I tried with qemuarm, it wasn't reproducible. But with imx6qsabresd from meta-fsl-arm, it was reproducible. So I believe we can generalize this patch. I will send the updated one shortly. Thanks for the pointer Ross.
Quoted 16 lines
Quoted 4 lines
Ross
--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
Signature · 7 lines
സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c
Quoted 22 lines · sujith h
Quoted 18 lines · sujith h
Quoted 12 lines · Ross
meta/recipes-multimedia/x264/x264_git.bb do_install() { · line 53
Quoted 4 lines · Sujith H
meta/recipes-multimedia/x264/x264_git.bb +2
-0+# PIC can't be enabled for 32-bit x86 and cyclone5 INSANE_SKIP_${PN}_append_x86 = " textrel" +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"Can this be generalised or is it absolutely specific to cyclone5? If it can't be generalised then I feel that this should belong in the cyclone5 BSP.
Quoted 8 lines
Quoted 3 lines
We found this with cyclone5 BSP. I will try to figure out how if we can see it with qemuarm or other BSP's too.
I tried with qemuarm, it wasn't reproducible. But with imx6qsabresd from meta-fsl-arm, it was reproducible. So I believe we can generalize this patch. I will send the updated one shortly. Thanks for the pointer Ross.
I forgot to mention that I posted this change in meta-altera for review. I got the feedback from meta-altera to post the change for review here:
https://github.com/kraj/meta-altera/pull/37. Sharing this for the reference.
Quoted 29 lines
Quoted 8 lines
Quoted 5 lines
Ross
Quoted 9 lines
--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
Signature · 7 lines
സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c