Skip to contentSkip to conversation

drm/i915: Add support for Kabylake to function obtaining shared PLL

PATCH In review Manasi Navare 3 participants 4 messages Sep 13, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Add support for Kabylake to function obtaining shared PLL

This adds support for KBL in the new function added in commit ID:
commit <f169660ed4e57a03e6f6ed07fe192dbcb7687a0d> that returns a shared pll in case of DDI platforms.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
index 8280548..8065a5f 100644
@@ -2427,7 +2427,7 @@ intel_ddi_get_link_dpll(struct intel_dp *intel_dp, int clock)
 			pll->config = tmp_pll_config;
 			return NULL;
 		}
-	} else if (IS_SKYLAKE(dev_priv)) {
+	} else if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
 		pll = skl_find_link_pll(dev_priv, clock);
 	} else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
 		pll = hsw_ddi_dp_get_dpll(encoder, clock);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Add support for Kabylake to function obtaining shared PLL

== Series Details ==

== Series Details ==

Series: drm/i915: Add support for Kabylake to function obtaining shared PLL
URL : https://patchwork.freedesktop.org/series/12370/
State : failure

== Summary ==

Series 12370v1 drm/i915: Add support for Kabylake to function obtaining shared PLL
https://patchwork.freedesktop.org/api/1.0/series/12370/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-hsw-4770k)
fi-bdw-5557u     total:254  pass:239  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:254  pass:208  dwarn:0   dfail:0   fail:0   skip:46 
fi-byt-n2820     total:254  pass:212  dwarn:0   dfail:0   fail:1   skip:41 
fi-hsw-4770k     total:212  pass:191  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:254  pass:228  dwarn:0   dfail:0   fail:0   skip:26 
fi-ilk-650       total:254  pass:184  dwarn:0   dfail:0   fail:2   skip:68 
fi-ivb-3520m     total:254  pass:223  dwarn:0   dfail:0   fail:0   skip:31 
fi-ivb-3770      total:254  pass:223  dwarn:0   dfail:0   fail:0   skip:31 
fi-skl-6260u     total:254  pass:240  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:254  pass:227  dwarn:0   dfail:0   fail:1   skip:26 
fi-skl-6700k     total:254  pass:225  dwarn:1   dfail:0   fail:0   skip:28 
fi-snb-2520m     total:254  pass:209  dwarn:0   dfail:0   fail:0   skip:45 
fi-snb-2600      total:254  pass:209  dwarn:0   dfail:0   fail:0   skip:45 

Results at /archive/results/CI_IGT_test/Patchwork_2517/

0cc042fc53f4a476e48494f6be8f74ec7296901f drm-intel-nightly: 2016y-09m-12d-21h-05m-37s UTC integration manifest d696413 drm/i915: Add support for Kabylake to function obtaining shared PLL

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Manasi Navare
Quoted 25 lines · Manasi Navare

This adds support for KBL in the new function added in commit ID:
commit <f169660ed4e57a03e6f6ed07fe192dbcb7687a0d> that returns a shared pll in case of DDI platforms.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -2
index 8280548..8065a5f 100644
@@ -2427,7 +2427,7 @@ intel_ddi_get_link_dpll(struct intel_dp *intel_dp, int clock)
                        pll->config = tmp_pll_config;
                        return NULL;
                }
-       } else if (IS_SKYLAKE(dev_priv)) {
+       } else if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
                pll = skl_find_link_pll(dev_priv, clock);
        } else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
                pll = hsw_ddi_dp_get_dpll(encoder, clock);
--

1.9.1

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Patch merged to dinq. Thanks for the patch.

Quoted 35 lines · Rodrigo Vivi
Quoted 23 lines · Manasi Navare

This adds support for KBL in the new function added in commit ID:
commit <f169660ed4e57a03e6f6ed07fe192dbcb7687a0d> that returns a shared pll in case of DDI platforms.

---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -2
index 8280548..8065a5f 100644
@@ -2427,7 +2427,7 @@ intel_ddi_get_link_dpll(struct intel_dp *intel_dp, int clock)
                        pll->config = tmp_pll_config;
                        return NULL;
                }
-       } else if (IS_SKYLAKE(dev_priv)) {
+       } else if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) {
                pll = skl_find_link_pll(dev_priv, clock);
        } else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
                pll = hsw_ddi_dp_get_dpll(encoder, clock);
--
Quoted 2 lines

1.9.1

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx