Skip to contentSkip to conversation

phy: sun4i-usb: Fix build dependency

PATCH In review Axel Lin 2 participants 2 messages Sep 16, 2016 Generic PHY framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 phy: sun4i-usb: Fix build dependency

of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below build error.

ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1

---
 drivers/phy/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/phy/Kconfig +2 -0
index cc27c12..b65aba0 100644
@@ -258,6 +258,8 @@ config PHY_SUN4I_USB
 	depends on RESET_CONTROLLER
 	depends on EXTCON
 	depends on POWER_SUPPLY
+	depends on USB_SUPPORT
+	select USB_COMMON
 	select GENERIC_PHY
 	help
 	  Enable this to support the transceiver that is part of Allwinner
Signature · 1 line
2.7.4
#1 lore raw

+Arnd

Hi,

Quoted 6 lines · Axel Lin

of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below build error.

ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1

Arnd was trying to solve the same issue.

Thanks
Kishon

Quoted 20 lines
---
 drivers/phy/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/phy/Kconfig +2 -0
index cc27c12..b65aba0 100644
@@ -258,6 +258,8 @@ config PHY_SUN4I_USB
 	depends on RESET_CONTROLLER
 	depends on EXTCON
 	depends on POWER_SUPPLY
+	depends on USB_SUPPORT
+	select USB_COMMON
 	select GENERIC_PHY
 	help
 	  Enable this to support the transceiver that is part of Allwinner