Skip to contentSkip to conversation

clocksource/fsl: Fix errata A-007728 for flextimer

PATCH New Meng Yi 1 participant 1 message Sep 22, 2016 Clocksource, clockevent drivers

lore
Share & tools
lore

Meng Yi

author
#0 lore raw

PATCH v3 1/1 clocksource/fsl: Fix errata A-007728 for flextimer

If the FTM counter reaches the FTM_MOD value between the reading of the TOF bit and the writing of 0 to the TOF bit, the process of clearing the TOF bit does not work as expected when FTMx_CONF[NUMTOF] != 0 and the current TOF count is less than FTMx_CONF[NUMTOF]. If the above condition is met, the TOF bit remains set. If the TOF interrupt is enabled (FTMx_SC[TOIE] = 1), the TOF interrupt also remains asserted.

Above is the errata discription

The workaround is clearing TOF bit until it is cleaned(FTM counter doesn't always reache the FTM_MOD anyway),which may cost some cycles.

---
Change from V1:
-add timeout into wile loop using a counter

---
 drivers/clocksource/fsl_ftm_timer.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/clocksource/fsl_ftm_timer.c +4 -4
index 738515b..97bdb09 100644
@@ -83,11 +83,11 @@ static inline void ftm_counter_disable(void __iomem *base)
 
 static inline void ftm_irq_acknowledge(void __iomem *base)
 {
-	u32 val;
+	u32 count = 100;
 
-	val = ftm_readl(base + FTM_SC);
-	val &= ~FTM_SC_TOF;
-	ftm_writel(val, base + FTM_SC);
+	while ((FTM_SC_TOF & ftm_readl(base + FTM_SC)) && count--)
+		ftm_writel(ftm_readl(base + FTM_SC) & (~FTM_SC_TOF),
+			   base + FTM_SC);
 }
 
 static inline void ftm_irq_enable(void __iomem *base)
Signature · 1 line
2.1.0.27.g96db324