FAILED: patch "[PATCH] efi: Fix handling error value in fdt_find_uefi_params" failed to apply to 4.7-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.7-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
4af9ed578a50cd331a725322cfd9d555251ce788Mon Sep 17 00:00:00 2001
From: Andrzej Hajda <[email protected]>
Date: Tue, 30 Aug 2016 12:41:37 +0200
Subject: [PATCH] efi: Fix handling error value in fdt_find_uefi_params
of_get_flat_dt_subnode_by_name can return negative value in case of error. Assigning the result to unsigned variable and checking if the variable is lesser than zero is incorrect and always false.
The patch fixes it by using signed variable to check the result.
The problem has been detected using semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
drivers/firmware/efi/efi.c +5 -2
@@ -657,9 +657,12 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname, }if (subnode) { - node =of_get_flat_dt_subnode_by_name (node, subnode); -if (node <0 ) +int err =of_get_flat_dt_subnode_by_name (node, subnode); + +if (err <0 )return 0 ; + + node = err; }return __find_uefi_params (node, info, dt_params[i].params);