Skip to contentSkip to conversation

Patch "genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 22, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
genirq-provide-irq_gc_-lock_irqsave-unlock_irqrestore-helpers.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ebf9ff753c041b296241990aef76163bbb2cc9c8 Mon Sep 17 00:00:00 2001

From: Boris Brezillon <[email protected]>
Date: Tue, 13 Sep 2016 15:58:28 +0200
Subject: genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers

From: Boris Brezillon <[email protected]>

commit ebf9ff753c041b296241990aef76163bbb2cc9c8 upstream.

Some irqchip drivers need to take the generic chip lock outside of the irq context.

Provide the irq_gc_{lock_irqsave,unlock_irqrestore}() helpers to allow one to disable irqs while entering a critical section protected by gc->lock.

Note that we do not provide optimized version of these helpers for !SMP, because they are not called from the hot-path.

[ tglx: Added a comment when these helpers should be [not] used ]

---
 include/linux/irq.h |   10 ++++++++++
 1 file changed, 10 insertions(+)
include/linux/irq.h +10 -0
@@ -933,6 +933,16 @@ static inline void irq_gc_lock(struct ir
 static inline void irq_gc_unlock(struct irq_chip_generic *gc) { }
 #endif
 
+/*
+ * The irqsave variants are for usage in non interrupt code. Do not use
+ * them in irq_chip callbacks. Use irq_gc_lock() instead.
+ */
+#define irq_gc_lock_irqsave(gc, flags)	\
+	raw_spin_lock_irqsave(&(gc)->lock, flags)
+
+#define irq_gc_unlock_irqrestore(gc, flags)	\
+	raw_spin_unlock_irqrestore(&(gc)->lock, flags)
+
 static inline void irq_reg_writel(struct irq_chip_generic *gc,
 				  u32 val, int reg_offset)
 {

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/irqchip-atmel-aic-fix-potential-deadlock-in-xlate.patch queue-4.7/drm-atmel-hlcdc-fix-vertical-scaling.patch queue-4.7/genirq-provide-irq_gc_-lock_irqsave-unlock_irqrestore-helpers.patch