EDAC, altera: Correct EDAC IRQ error message.
Subsystems (2)
PATCH 1/2 EDAC, altera: Correct EDAC IRQ error message.
From: Thor Thayer <[email protected]>
Correct the error message sent out in the case of a single bit error IRQ allocation.
Signed-off-by Thor Thayer <[email protected]>
--- drivers/edac/altera_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/altera_edac.c +1 -1
@@ -1749,7 +1749,7 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, prv->ecc_irq_handler, IRQF_SHARED, ecc_name, altdev);if (rc) { -edac_printk (KERN_ERR ,EDAC_DEVICE ,"No DBERR IRQ resource\n" ); +edac_printk (KERN_ERR ,EDAC_DEVICE ,"No SBERR IRQ resource\n" ); goto err_release_group1; }
Signature · 1 line
1.7.9.5
PATCH 2/2 EDAC, altera: Add IRQ Flags to disable IRQ while handling
From: Thor Thayer <[email protected]>
Add the IRQF_ONESHOT and IRQF_TRIGGER_HIGH flags to disable the IRQ while executing the IRQ handler. Remove the IRQF_SHARED because these are not shared IRQs in the domain. Exposed when flooding IRQs.
Signed-off-by Thor Thayer <[email protected]>
--- drivers/edac/altera_edac.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/edac/altera_edac.c +10 -8
@@ -1445,7 +1445,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) } rc =devm_request_irq (&altdev->ddev, altdev->sb_irq, prv->ecc_irq_handler, -IRQF_SHARED , ecc_name, altdev); +IRQF_ONESHOT |IRQF_TRIGGER_HIGH , + ecc_name, altdev);if (rc) {edac_printk (KERN_ERR ,EDAC_DEVICE ,"PortB SBERR IRQ error\n" ); goto err_release_group_1;
@@ -1459,7 +1460,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) } rc =devm_request_irq (&altdev->ddev, altdev->db_irq, prv->ecc_irq_handler, -IRQF_SHARED , ecc_name, altdev); +IRQF_ONESHOT |IRQF_TRIGGER_HIGH , + ecc_name, altdev);if (rc) {edac_printk (KERN_ERR ,EDAC_DEVICE ,"PortB DBERR IRQ error\n" ); goto err_release_group_1;
@@ -1745,9 +1747,9 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, rc = -ENODEV ; goto err_release_group1; } - rc =devm_request_irq (edac->dev, altdev->sb_irq, - prv->ecc_irq_handler, -IRQF_SHARED , ecc_name, altdev); + rc =devm_request_irq (edac->dev, altdev->sb_irq, prv->ecc_irq_handler, +IRQF_ONESHOT |IRQF_TRIGGER_HIGH , + ecc_name, altdev);if (rc) {edac_printk (KERN_ERR ,EDAC_DEVICE ,"No SBERR IRQ resource\n" ); goto err_release_group1;
@@ -1759,9 +1761,9 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, rc = -ENODEV ; goto err_release_group1; } - rc =devm_request_irq (edac->dev, altdev->db_irq, - prv->ecc_irq_handler, -IRQF_SHARED , ecc_name, altdev); + rc =devm_request_irq (edac->dev, altdev->db_irq, prv->ecc_irq_handler, +IRQF_ONESHOT |IRQF_TRIGGER_HIGH , + ecc_name, altdev);if (rc) {edac_printk (KERN_ERR ,EDAC_DEVICE ,"No DBERR IRQ resource\n" ); goto err_release_group1;
Signature · 1 line
1.7.9.5
Borislav Petkov
maintainerQuoted 9 lines · On Thu, Sep 22, 2016 at 05:13:38PM -0500, [email protected] wrote:
From: Thor Thayer <[email protected]>
Correct the error message sent out in the case of a single bit error IRQ allocation.
Signed-off-by Thor Thayer <[email protected]>--- drivers/edac/altera_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Both applied,
thanks.
Signature · 4 lines
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.