Skip to contentSkip to conversation

phytool: Add recipe

PATCH Superseded Mike Looijmans 3 participants 12 messages Sep 23, 2016 – Oct 6, 2016

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phytool: Add recipe

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
meta-networking/recipes-support/phytool/phytool.bb new file +14 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${prefix}/bin
+	oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
Signature · 1 line
1.9.1
#1 lore raw
Quoted 18 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
meta-networking/recipes-support/phytool/phytool.bb new file +2 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"

meta-networking/recipes-support/phytool/phytool.bb line 12

Quoted 10 lines
meta-networking/recipes-support/phytool/phytool.bb new file +10 -0
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin

perhaps use base_bindir here

Quoted 10 lines
meta-networking/recipes-support/phytool/phytool.bb new file +2 -1
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 23 lines · Khem Raj
Quoted 22 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
  meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

create mode 100644 meta-networking/recipes-support/phytool/phytool.bb

meta-networking/recipes-support/phytool/phytool.bb new file +6 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 12

Quoted 6 lines
meta-networking/recipes-support/phytool/phytool.bb new file +6 -0
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin

perhaps use base_bindir here

The makefile installs to $PREFIX/bin so I deliberately put the same folder in the recipe (the makefile doesn't create the directory). If anyone changes $bindir the install will fail.

Quoted 11 lines
Quoted 11 lines
meta-networking/recipes-support/phytool/phytool.bb new file +2 -1
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Mike Looijmans
#3 lore raw
Quoted 39 lines · Mike Looijmans
Quoted 28 lines · Khem Raj
Quoted 25 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
  meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

create mode 100644 meta-networking/recipes-support/phytool/phytool.bb

meta-networking/recipes-support/phytool/phytool.bb new file +7 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git"
Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 12

Quoted 5 lines
meta-networking/recipes-support/phytool/phytool.bb new file +5 -0
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin

perhaps use base_bindir here

Quoted 3 lines

The makefile installs to $PREFIX/bin so I deliberately put the same folder in the recipe (the makefile doesn't create the directory). If anyone changes $bindir the install will fail.

I see the logic, if you dont want to use bitbake variables then perhaps its good to add a comment to explain why it was not done

Quoted 23 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/phytool/phytool.bb new file +2 -1
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Mike Looijmans

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw

2 more issues:

WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file phytool/1.0.1-r0/git/COPYING to phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such file or directory: 'phytool/1.0.1-r0/git/COPYING'
ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool:
LIC_FILES_CHKSUM points to an invalid file:
phytool/1.0.1-r0/git/COPYING [license-checksum]
NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded
...

NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa

Quoted 84 lines · Khem Raj
Quoted 3 lines · Mike Looijmans
Quoted 2 lines · Khem Raj

On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <

[email protected]>

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines · wrote:

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
  meta-networking/recipes-support/phytool/phytool.bb | 14

++++++++++++++

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
  1 file changed, 14 insertions(+)

create mode 100644 meta-networking/recipes-support/phytool/

phytool.bb

Quoted 11 lines
Quoted 11 lines

meta-networking/recipes-support/phytool/phytool.bb line 3

Quoted 11 lines
meta-networking/recipes-support/phytool/phytool.bb new file +3 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae1

9f"

Quoted 14 lines
Quoted 4 lines
Quoted 4 lines
meta-networking/recipes-support/phytool/phytool.bb new file +4 -0
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git"
Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 12

Quoted 5 lines
meta-networking/recipes-support/phytool/phytool.bb new file +5 -0
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin

perhaps use base_bindir here

Quoted 1 line

The makefile installs to $PREFIX/bin so I deliberately put the same

folder

Quoted 1 line

in the recipe (the makefile doesn't create the directory). If anyone

changes

Quoted 1 line

$bindir the install will fail.

I see the logic, if you dont want to use bitbake variables then perhaps its
good to add a comment to explain why it was not done

Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/phytool/phytool.bb new file +2 -1
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 8 lines

--
Mike Looijmans

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
Quoted 11 lines · Martin Jansa

2 more issues:

WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file phytool/1.0.1-r0/git/COPYING to phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such file or directory: 'phytool/1.0.1-r0/git/COPYING'
ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool:
LIC_FILES_CHKSUM points to an invalid file:
phytool/1.0.1-r0/git/COPYING [license-checksum]
NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded
...

Weird, it didn't barf on that on my system until I cleaned it and started over. Ah well, I;ll send a v2 which fixes it.

Quoted 10 lines

NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa

I have no clue what that means. I also have no clue what I'm supposed to do about it. And on my build it was only a warning.

Quoted 61 lines · Khem Raj
Quoted 58 lines
Quoted 3 lines · Mike Looijmans
Quoted 2 lines · Khem Raj

On Fri, Sep 23, 2016 at 5:33 AM, Mike Looijmans <

[email protected]>

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines · wrote:

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
   meta-networking/recipes-support/phytool/phytool.bb | 14

++++++++++++++

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
   1 file changed, 14 insertions(+)

create mode 100644 meta-networking/recipes-support/phytool/

phytool.bb

Quoted 11 lines
Quoted 11 lines

meta-networking/recipes-support/phytool/phytool.bb line 3

Quoted 11 lines
meta-networking/recipes-support/phytool/phytool.bb new file +3 -0
new file mode 100644
index 0000000..9d541b7
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae1

9f"

Quoted 14 lines
Quoted 4 lines
Quoted 4 lines
meta-networking/recipes-support/phytool/phytool.bb new file +4 -0
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git"
Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 12

Quoted 5 lines
meta-networking/recipes-support/phytool/phytool.bb new file +5 -0
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin

perhaps use base_bindir here

Quoted 1 line

The makefile installs to $PREFIX/bin so I deliberately put the same

folder

Quoted 1 line

in the recipe (the makefile doesn't create the directory). If anyone

changes

Quoted 1 line

$bindir the install will fail.

I see the logic, if you dont want to use bitbake variables then perhaps its
good to add a comment to explain why it was not done

Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/phytool/phytool.bb new file +2 -1
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

--

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

_______________________________________________

Quoted 20 lines
Quoted 20 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 8 lines

--
Mike Looijmans

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#6 lore raw
Quoted 27 lines · Mike Looijmans
Quoted 11 lines · Martin Jansa

2 more issues:

WARNING: phytool-1.0.1-r0 do_populate_lic: Could not copy license file phytool/1.0.1-r0/git/COPYING to phytool/1.0.1-r0/license-destdir/phytool/COPYING: [Errno 2] No such file or directory: 'phytool/1.0.1-r0/git/COPYING'
ERROR: phytool-1.0.1-r0 do_populate_lic: QA Issue: phytool:
LIC_FILES_CHKSUM points to an invalid file:
phytool/1.0.1-r0/git/COPYING [license-checksum]
NOTE: recipe phytool-1.0.1-r0: task do_populate_lic: Succeeded
...

Weird, it didn't barf on that on my system until I cleaned it and started over. Ah well, I;ll send a v2 which fixes it.

Quoted 10 lines

NOTE: recipe phytool-1.0.1-r0: task do_package_qa: Started
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'phytool/1.0.1-r0/packages-split/phytool/usr/bin/phytool' [ldflags]
ERROR: phytool-1.0.1-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
ERROR: phytool-1.0.1-r0 do_package_qa: Function failed: do_package_qa

Quoted 2 lines

I have no clue what that means. I also have no clue what I'm supposed to do about it. And on my build it was only a warning.

A bit of experimentation revealed that apparently this is OE complaining that $LDFLAGS didn't get passed to the linker. Created a patch to solve that and upstream it.

It would be helpful if the message wasn't so cryptic.

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

#7 lore raw

PATCH v2 1/1 phytool: Add recipe

In reply to Martin Jansa

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
v2: Fix LICENSE filename and checksum
Honor LDFLAGS value (patch accepted upstream)

 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
meta-networking/recipes-support/phytool/phytool.bb new file +14 -0
new file mode 100644
index 0000000..d451aa9
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
+
+PV = "1.0.1"
+SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${prefix}/bin
+	oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
Signature · 1 line
1.9.1
#8 lore raw
Quoted 19 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
v2: Fix LICENSE filename and checksum
Honor LDFLAGS value (patch accepted upstream)

 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
meta-networking/recipes-support/phytool/phytool.bb new file +0 -0
new file mode 100644
index 0000000..d451aa9

meta-networking/recipes-support/phytool/phytool.bb line 5

Quoted 5 lines
meta-networking/recipes-support/phytool/phytool.bb new file +5 -0
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
+
+PV = "1.0.1"

perhaps its better to include SRCPV in PV above since the SRCREV below is really 1.0.1+some more commits. moreover we get srcrev accounted for task hashes

Quoted 17 lines
meta-networking/recipes-support/phytool/phytool.bb new file +9 -1
+SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#9 lore raw
Quoted 30 lines · Khem Raj
Quoted 19 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
v2: Fix LICENSE filename and checksum
Honor LDFLAGS value (patch accepted upstream)

 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
meta-networking/recipes-support/phytool/phytool.bb new file +0 -0
new file mode 100644
index 0000000..d451aa9

meta-networking/recipes-support/phytool/phytool.bb line 5

Quoted 5 lines
meta-networking/recipes-support/phytool/phytool.bb new file +5 -0
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
+
+PV = "1.0.1"

perhaps its better to include SRCPV in PV above since the SRCREV below is really 1.0.1+some more commits. moreover we get srcrev accounted for task hashes

Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 13

Quoted 8 lines
meta-networking/recipes-support/phytool/phytool.bb new file +8 -0
+SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install

We're not using tabs for indentation.
see http://www.openembedded.org/wiki/Styleguide

Quoted 14 lines
Quoted 9 lines
meta-networking/recipes-support/phytool/phytool.bb new file +1 -1
+}
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#10 lore raw
Quoted 15 lines · Martin Jansa
Quoted 14 lines · Khem Raj
Quoted 13 lines · Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
v2: Fix LICENSE filename and checksum
Honor LDFLAGS value (patch accepted upstream)

 meta-networking/recipes-support/phytool/phytool.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
meta-networking/recipes-support/phytool/phytool.bb new file +1 -0
new file mode 100644
index 0000000..d451aa9
@@ -0,0 +1,14 @@
+SUMMARY = "PHY interface tool for Linux"
Quoted 8 lines

meta-networking/recipes-support/phytool/phytool.bb line 5

Quoted 4 lines
meta-networking/recipes-support/phytool/phytool.bb new file +4 -0
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
+
+PV = "1.0.1"

perhaps its better to include SRCPV in PV above since the SRCREV below is really 1.0.1+some more commits. moreover we get srcrev accounted for task hashes

Will do.

Quoted 12 lines
Quoted 9 lines

meta-networking/recipes-support/phytool/phytool.bb line 13

Quoted 9 lines
meta-networking/recipes-support/phytool/phytool.bb new file +8 -0
+SRCREV = "3149bfdb4f513e2f0da0a7d0bc5d0873578696f2"
+SRC_URI = "git://github.com/wkz/phytool.git"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+       install -d ${D}${prefix}/bin
+       oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install

We're not using tabs for indentation.
see http://www.openembedded.org/wiki/Styleguide

Will fix in v3.

I also want to move it to another location in meta-oe, because meta-networking depends on meta-python and it's really weird to have to add meta-python to your layers just to get a simple C binary tool.

Mike.

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

#11 lore raw

PATCH v2 1/1 phytool: Add recipe

In reply to Mike Looijmans

A nice tool to directly read, write and interpret ethernet PHY data. Very useful when debugging PHY or MDIO problems, which ethtool does not do.

---
v2:
Add $bindir comment
Add patch (pending upstream) to fix LDFLAGS warning Fix license filename

 meta-networking/recipes-support/phytool/phytool.bb | 17 ++++++++++++
 .../0001-Makefile-Honor-LDFLAGS-variable.patch     | 31 ++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 meta-networking/recipes-support/phytool/phytool.bb
 create mode 100644 meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch
meta-networking/recipes-support/phytool/phytool.bb new file +17 -0
new file mode 100644
index 0000000..e95b035
@@ -0,0 +1,17 @@
+SUMMARY = "PHY interface tool for Linux"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0"
+
+PV = "1.0.1"
+SRCREV = "1a3ea62a218206e9faf3b27fb5d01c85692024c8"
+SRC_URI = "git://github.com/wkz/phytool.git \
+	file://0001-Makefile-Honor-LDFLAGS-variable.patch"
+
+S = "${WORKDIR}/git"
+
+# Intentionally not using $bindir here because the Makefile is hard-coded to
+# install into $PREFIX/bin
+do_install() {
+	install -d ${D}${prefix}/bin
+	oe_runmake 'DESTDIR=${D}' 'PREFIX=${prefix}' install
+}
meta-networking/recipes-support/phytool/phytool/0001-Makefile-Honor-LDFLAGS-variable.patch new file +31 -0
new file mode 100644
index 0000000..8b99d09
@@ -0,0 +1,31 @@
+From 8b75a5e6238fe30661b672743560fe4d357237fd Mon Sep 17 00:00:00 2001
+From: Mike Looijmans <[email protected]>
+Date: Wed, 28 Sep 2016 09:42:45 +0200
+Subject: [PATCH] Makefile: Honor LDFLAGS variable
+
+Passing $(LDFLAGS) to the linker is important for cross-compile environments.
+OpenEmbedded builds will display QA errors like this:
+... QA Issue: No GNU_HASH in the elf binary ... [ldflags]
+
+Upstream-Status: Pending
+Signed-off-by: Mike Looijmans <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index b52843b..70bb414 100644
+--- a/Makefile
++++ b/Makefile
+@@ -22,7 +22,7 @@ hdrs = $(wildcard *.h)
+ 
+ phytool: $(objs)
+ 	@printf "  CC      $(subst $(ROOTDIR)/,,$(shell pwd)/$@)\n"
+-	@$(CC) $(LDLIBS) -o $@ $^
++	@$(CC) $(LDFLAGS) $(LDLIBS) -o $@ $^
+ 
+ all: phytool
+ 
+-- 
+1.9.1
+
Signature · 1 line
1.9.1