Skip to contentSkip to conversation

openrisc: Define __ro_after_init to avoid crash

PATCH In review Guenter Roeck 2 participants 3 messages Sep 24, 2016 – Sep 27, 2016 Openrisc architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openrisc: Define __ro_after_init to avoid crash

openrisc qemu tests fail with the following crash.

Unable to handle kernel access at virtual address 0xc0300c34

Oops#: 0001

CPU #: 0
PC: c016c710 SR: 0000ae67 SP: c1017e04
GPR00: 00000000 GPR01: c1017e04 GPR02: c0300c34 GPR03: c0300c34
GPR04: 00000000 GPR05: c0300cb0 GPR06: c0300c34 GPR07: 000000ff
GPR08: c107f074 GPR09: c0199ef4 GPR10: c1016000 GPR11: 00000000
GPR12: 00000000 GPR13: c107f044 GPR14: c0473774 GPR15: 07ce0000
GPR16: 00000000 GPR17: c107ed8a GPR18: 00009600 GPR19: c107f044
GPR20: c107ee74 GPR21: 00000003 GPR22: c0473770 GPR23: 00000033
GPR24: 000000bf GPR25: 00000019 GPR26: c046400c GPR27: 00000001
GPR28: c0464028 GPR29: c1018000 GPR30: 00000006 GPR31: ccf37483

     RES: 00000000 oGPR11: ffffffff
     Process swapper (pid: 1, stackpage=c1001960)

     Stack: Stack dump [0xc1017cf8]:
     sp + 00: 0xc1017e04
     sp + 04: 0xc0300c34
     sp + 08: 0xc0300c34
     sp + 12: 0x00000000

...

Bisect points to commit d2ec3f77de8e ("pty: make ptmx file ops read-only after init"). Fix by defining __ro_after_init for the openrisc architecture, similar to parisc.

Fixes d2ec3f77de8e ("pty: make ptmx file ops read-only after init")
Cc Kees Cook <[email protected]>
---
 arch/openrisc/include/asm/cache.h | 2 ++
 1 file changed, 2 insertions(+)
arch/openrisc/include/asm/cache.h +2 -0
index 4ce7a01a252d..5f55da9cbfd5 100644
@@ -23,6 +23,8 @@
  * they shouldn't be hard-coded!
  */
 
+#define __ro_after_init __read_mostly
+
 #define L1_CACHE_BYTES 16
 #define L1_CACHE_SHIFT 4
 
Signature · 1 line
2.5.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Guenter Roeck

openrisc qemu tests fail with the following crash.

Unable to handle kernel access at virtual address 0xc0300c34

Oops#: 0001

CPU #: 0
PC: c016c710 SR: 0000ae67 SP: c1017e04
GPR00: 00000000 GPR01: c1017e04 GPR02: c0300c34 GPR03: c0300c34
GPR04: 00000000 GPR05: c0300cb0 GPR06: c0300c34 GPR07: 000000ff
GPR08: c107f074 GPR09: c0199ef4 GPR10: c1016000 GPR11: 00000000
GPR12: 00000000 GPR13: c107f044 GPR14: c0473774 GPR15: 07ce0000
GPR16: 00000000 GPR17: c107ed8a GPR18: 00009600 GPR19: c107f044
GPR20: c107ee74 GPR21: 00000003 GPR22: c0473770 GPR23: 00000033
GPR24: 000000bf GPR25: 00000019 GPR26: c046400c GPR27: 00000001
GPR28: c0464028 GPR29: c1018000 GPR30: 00000006 GPR31: ccf37483

    RES: 00000000 oGPR11: ffffffff
    Process swapper (pid: 1, stackpage=c1001960)

    Stack: Stack dump [0xc1017cf8]:
    sp + 00: 0xc1017e04
    sp + 04: 0xc0300c34
    sp + 08: 0xc0300c34
    sp + 12: 0x00000000
Quoted 5 lines

...

Bisect points to commit d2ec3f77de8e ("pty: make ptmx file ops read-only after init"). Fix by defining __ro_after_init for the openrisc architecture, similar to parisc.

Thanks for finding this one.
Just for clatify __read_mostly falls back to default blank in openrisc, so it gets no special section treatment.

Quoted 24 lines
Fixes d2ec3f77de8e ("pty: make ptmx file ops read-only after init")
Cc Kees Cook <[email protected]>

---
arch/openrisc/include/asm/cache.h | 2 ++

1 file changed, 2 insertions(+)
arch/openrisc/include/asm/cache.h +2 -0
index 4ce7a01a252d..5f55da9cbfd5 100644
@@ -23,6 +23,8 @@
 * they shouldn't be hard-coded!
 */
 
+#define __ro_after_init __read_mostly
+
 #define L1_CACHE_BYTES 16
 #define L1_CACHE_SHIFT 4
 
Signature · 1 line
2.5.0
#2 lore raw
Quoted 29 lines · Stafford Horne
Quoted 25 lines · Guenter Roeck

openrisc qemu tests fail with the following crash.

Unable to handle kernel access at virtual address 0xc0300c34

Oops#: 0001

CPU #: 0
PC: c016c710 SR: 0000ae67 SP: c1017e04
GPR00: 00000000 GPR01: c1017e04 GPR02: c0300c34 GPR03: c0300c34
GPR04: 00000000 GPR05: c0300cb0 GPR06: c0300c34 GPR07: 000000ff
GPR08: c107f074 GPR09: c0199ef4 GPR10: c1016000 GPR11: 00000000
GPR12: 00000000 GPR13: c107f044 GPR14: c0473774 GPR15: 07ce0000
GPR16: 00000000 GPR17: c107ed8a GPR18: 00009600 GPR19: c107f044
GPR20: c107ee74 GPR21: 00000003 GPR22: c0473770 GPR23: 00000033
GPR24: 000000bf GPR25: 00000019 GPR26: c046400c GPR27: 00000001
GPR28: c0464028 GPR29: c1018000 GPR30: 00000006 GPR31: ccf37483

    RES: 00000000 oGPR11: ffffffff
    Process swapper (pid: 1, stackpage=c1001960)

    Stack: Stack dump [0xc1017cf8]:
    sp + 00: 0xc1017e04
    sp + 04: 0xc0300c34
    sp + 08: 0xc0300c34
    sp + 12: 0x00000000

...

Quoted 7 lines
Quoted 3 lines

Bisect points to commit d2ec3f77de8e ("pty: make ptmx file ops read-only after init"). Fix by defining __ro_after_init for the openrisc architecture, similar to parisc.

Thanks for finding this one.
Just for clatify __read_mostly falls back to default blank in openrisc, so it gets no special section treatment.

Yes, I understand. It falls back to the pre-_ro_after_init behavior, which should be perfectly fine here.

Guenter

Quoted 28 lines
Quoted 24 lines
Fixes d2ec3f77de8e ("pty: make ptmx file ops read-only after init")
Cc Kees Cook <[email protected]>

---
arch/openrisc/include/asm/cache.h | 2 ++

1 file changed, 2 insertions(+)
arch/openrisc/include/asm/cache.h +2 -1
index 4ce7a01a252d..5f55da9cbfd5 100644
@@ -23,6 +23,8 @@
 * they shouldn't be hard-coded!
 */
 
+#define __ro_after_init __read_mostly
+
 #define L1_CACHE_BYTES 16
 #define L1_CACHE_SHIFT 4
 
--

2.5.0