Skip to contentSkip to conversation

Patch "pwm: Mark all devices as "might sleep"" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 27, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pwm: Mark all devices as "might sleep"

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pwm-mark-all-devices-as-might-sleep.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ff01c944cfa939f3474c28d88223213494aedf0b Mon Sep 17 00:00:00 2001

From: Thierry Reding <[email protected]>
Date: Thu, 21 Jan 2016 15:04:59 +0100
Subject: pwm: Mark all devices as "might sleep"

From: Thierry Reding <[email protected]>

commit ff01c944cfa939f3474c28d88223213494aedf0b upstream.

Commit d1cd21427747 ("pwm: Set enable state properly on failed call to enable") introduced a mutex that is needed to protect internal state of PWM devices. Since that mutex is acquired in pwm_set_polarity() and in pwm_enable() and might potentially block, all PWM devices effectively become "might sleep".

It's rather pointless to keep the .can_sleep field around, but given that there are external users let's postpone the removal for the next release cycle.

Fixes d1cd21427747 ("pwm: Set enable state properly on failed call to enable")
---
 drivers/pwm/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/core.c +1 -1
@@ -889,7 +889,7 @@ EXPORT_SYMBOL_GPL(devm_pwm_put);
   */
 bool pwm_can_sleep(struct pwm_device *pwm)
 {
-	return pwm->chip->can_sleep;
+	return true;
 }
 EXPORT_SYMBOL_GPL(pwm_can_sleep);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/pwm-mark-all-devices-as-might-sleep.patch