Patch "i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended" has been added to the 4.7-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
i2c-qup-skip-qup_i2c_suspend-if-the-device-is-already-runtime-suspended.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
331dcf421c34d227784d07943eb01e4023a42b0aMon Sep 17 00:00:00 2001
From: Sudeep Holla <[email protected]>
Date: Thu, 25 Aug 2016 12:23:39 +0100
Subject: i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended
From: Sudeep Holla <[email protected]>
commit 331dcf421c34d227784d07943eb01e4023a42b0a upstream.
If the i2c device is already runtime suspended, if qup_i2c_suspend is executed during suspend-to-idle or suspend-to-ram it will result in the following splat:
WARNING: CPU: 3 PID: 1593 at drivers/clk/clk.c:476 clk_core_unprepare+0x80/0x90 Modules linked in: CPU: 3 PID: 1593 Comm: bash Tainted: G W 4.8.0-rc3 #14 Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) PC is at clk_core_unprepare+0x80/0x90 LR is at clk_unprepare+0x28/0x40 pc : [<ffff0000086eecf0>] lr : [<ffff0000086f0c58>] pstate: 60000145 Call trace: clk_core_unprepare+0x80/0x90 qup_i2c_disable_clocks+0x2c/0x68 qup_i2c_suspend+0x10/0x20 platform_pm_suspend+0x24/0x68 ...
This patch fixes the issue by executing qup_i2c_pm_suspend_runtime conditionally in qup_i2c_suspend.
--- drivers/i2c/busses/i2c-qup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-qup.c +2 -1
@@ -1610,7 +1610,8 @@ static int qup_i2c_pm_resume_runtime(str#ifdef CONFIG_PM_SLEEP static int qup_i2c_suspend (struct device *device) { -qup_i2c_pm_suspend_runtime (device); +if (!pm_runtime_suspended (device)) +return qup_i2c_pm_suspend_runtime (device);return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/i2c-qup-skip-qup_i2c_suspend-if-the-device-is-already-runtime-suspended.patch