Patch "libceph: add an ONSTACK initializer for oids" has been added to the 4.7-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
libceph: add an ONSTACK initializer for oids
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
libceph-add-an-onstack-initializer-for-oids.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
281dbe5db81c6137def9757e07a7aea14b1ed86eMon Sep 17 00:00:00 2001
From: Ilya Dryomov <[email protected]>
Date: Tue, 26 Jul 2016 15:22:35 +0200
Subject: libceph: add an ONSTACK initializer for oids
From: Ilya Dryomov <[email protected]>
commit 281dbe5db81c6137def9757e07a7aea14b1ed86e upstream.
An on-stack oid in ceph_ioctl_get_dataloc() is not initialized, resulting in a WARN and a NULL pointer dereference later on. We will have more of these on-stack in the future, so fix it with a convenience macro.
--- fs/ceph/ioctl.c | 2 +- include/linux/ceph/osdmap.h | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)
fs/ceph/ioctl.c +1 -1
@@ -183,7 +183,7 @@ static long ceph_ioctl_get_dataloc(strucstruct ceph_osd_client *osdc = &ceph_sb_to_client (inode->i_sb)->client->osdc;struct ceph_object_locator oloc; -struct ceph_object_id oid; +CEPH_DEFINE_OID_ONSTACK (oid);u64 len =1 , olen;u64 tmp;struct ceph_pg pgid;
include/linux/ceph/osdmap.h +5 -0
@@ -115,6 +115,11 @@ static inline void ceph_oid_init(struct oid->name_len =0 ; } +#define CEPH_OID_INIT_ONSTACK (oid) \ + ({ ceph_oid_init(&oid); oid; }) +#define CEPH_DEFINE_OID_ONSTACK (oid) \ + struct ceph_object_id oid = CEPH_OID_INIT_ONSTACK(oid) +static inline bool ceph_oid_empty (const struct ceph_object_id *oid) {return oid->name == oid->inline_name && !oid->name_len;
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/ceph-fix-symbol-versioning-for-ceph_monc_do_statfs.patch queue-4.7/libceph-fix-return-value-check-in-alloc_msg_with_page_vector.patch queue-4.7/libceph-add-an-onstack-initializer-for-oids.patch