Skip to contentSkip to conversation

wic: selftest: add test for mksystemd-bootdisk

PATCH In review Ed Bartosh 2 participants 3 messages Sep 29, 2016 – Sep 30, 2016

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 wic: selftest: add test for mksystemd-bootdisk

Test creation of mksystemd-bootdisk image.

Signed-off-by Ed Bartosh <[email protected]>
---
 meta/lib/oeqa/selftest/wic.py | 7 +++++++
 1 file changed, 7 insertions(+)
meta/lib/oeqa/selftest/wic.py +7 -0
index e550785..6012abc 100644
@@ -284,3 +284,10 @@ class Wic(oeSelfTest):
         self.assertEqual(0, status)
         self.assertEqual(1, len(glob(self.resultdir + "%s-*direct" % image)))
         self.assertEqual(1, len(glob(self.resultdir + "%s-*direct.bmap" % image)))
+
+    def test_mksystemd_bootdisk(self):
+        """Test creation of mksystemd-bootdisk image"""
+        image = "mksystemd-bootdisk"
+        self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" \
+                                   % image).status)
+        self.assertEqual(1, len(glob(self.resultdir + "%s-*direct" % image)))
Signature · 1 line
2.1.4
#1 lore raw
Quoted 8 lines · Ed Bartosh
meta/lib/oeqa/selftest/wic.py +6 -0
+    def test_mksystemd_bootdisk(self):
+        """Test creation of mksystemd-bootdisk image"""
+        image = "mksystemd-bootdisk"
+        self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" \
+                                   % image).status)
+        self.assertEqual(1, len(glob(self.resultdir + "%s-*direct" %

image)))

Jianxun sent a patch to rename this image to just systemd-bootdisk, do you agree with this rename (so can you update the patch) or do you think we should not rename?

Ross

author
#2 lore raw
Quoted 12 lines · Ross
Quoted 8 lines · Ed Bartosh
meta/lib/oeqa/selftest/wic.py +6 -0
+    def test_mksystemd_bootdisk(self):
+        """Test creation of mksystemd-bootdisk image"""
+        image = "mksystemd-bootdisk"
+        self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" \
+                                   % image).status)
+        self.assertEqual(1, len(glob(self.resultdir + "%s-*direct" %

image)))

Quoted 4 lines

Jianxun sent a patch to rename this image to just systemd-bootdisk, do you agree with this rename (so can you update the patch) or do you think we should not rename?

I agree with rename. I'll send updated patchset after Jianxun patch is merged.

Signature · 2 lines
Regards,
Ed