Skip to contentSkip to conversation

Patch "tools/vm/slabinfo: fix an unintentional printf" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 4, 2016 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

tools/vm/slabinfo: fix an unintentional printf

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
tools-vm-slabinfo-fix-an-unintentional-printf.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2d6a4d64812bb12dda53704943b61a7496d02098 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 20 Jul 2016 15:45:05 -0700
Subject: tools/vm/slabinfo: fix an unintentional printf

From: Dan Carpenter <[email protected]>

commit 2d6a4d64812bb12dda53704943b61a7496d02098 upstream.

The curly braces are missing here so we print stuff unintentionally.

Fixes 9da4714a2d44 ('slub: slabinfo update for cmpxchg handling')
Cc Sergey Senozhatsky <[email protected]>
Cc Colin Ian King <[email protected]>
Cc Laura Abbott <[email protected]>
---
 tools/vm/slabinfo.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/vm/slabinfo.c +2 -1
@@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *
 			s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
 	}
 
-	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
+	if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
 		printf("\nCmpxchg_double Looping\n------------------------\n");
 		printf("Locked Cmpxchg Double redos   %lu\nUnlocked Cmpxchg Double redos %lu\n",
 			s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
+	}
 }
 
 static void report(struct slabinfo *s)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mmc-pxamci-fix-potential-oops.patch queue-4.4/tools-vm-slabinfo-fix-an-unintentional-printf.patch