Patch "i40iw: Receive notification events correctly" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
i40iw: Receive notification events correctly
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
i40iw-receive-notification-events-correctly.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b71121b4b70a995c0b794026e84c880c4f26c361Mon Sep 17 00:00:00 2001
From: Shiraz Saleem <[email protected]>
Date: Thu, 25 Aug 2016 11:53:24 -0500
Subject: i40iw: Receive notification events correctly
From: Shiraz Saleem <[email protected]>
commit b71121b4b70a995c0b794026e84c880c4f26c361 upstream.
Device notifications are not received after the first interface is closed; since there is an unregister for notifications on every interface close. Correct this by unregistering for device notifications only when the last interface is closed. Also, make all operations on the i40iw_notifiers_registered atomic as it can be read/modified concurrently.
--- drivers/infiniband/hw/i40iw/i40iw_main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/infiniband/hw/i40iw/i40iw_main.c +3 -5
@@ -100,7 +100,7 @@ static struct notifier_block i40iw_net_n .notifier_call = i40iw_net_event }; -static int i40iw_notifiers_registered; +static atomic_t i40iw_notifiers_registered;/** * i40iw_find_i40e_handler - find a handler given a client info
@@ -1342,12 +1342,11 @@ exit:*/ static void i40iw_register_notifiers (void ) { -if (!i40iw_notifiers_registered) { +if (atomic_inc_return (&i40iw_notifiers_registered) ==1 ) {register_inetaddr_notifier (&i40iw_inetaddr_notifier);register_inet6addr_notifier (&i40iw_inetaddr6_notifier);register_netevent_notifier (&i40iw_net_notifier); } - i40iw_notifiers_registered++; }/**
@@ -1429,8 +1428,7 @@ static void i40iw_deinit_device(struct ii40iw_del_macip_entry (iwdev, (u8 )iwdev->mac_ip_table_idx);/* fallthrough */ case INET_NOTIFIER : -if (i40iw_notifiers_registered >0 ) { - i40iw_notifiers_registered--; +if (!atomic_dec_return (&i40iw_notifiers_registered)) {unregister_netevent_notifier (&i40iw_net_notifier);unregister_inetaddr_notifier (&i40iw_inetaddr_notifier);unregister_inet6addr_notifier (&i40iw_inetaddr6_notifier);
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/i40iw-update-hw_iwarp_state.patch queue-4.7/i40iw-add-missing-check-for-interface-already-open.patch queue-4.7/i40iw-fix-double-free-of-allocated_buffer.patch queue-4.7/i40iw-send-last-streaming-mode-message-for-loopback-connections.patch queue-4.7/i40iw-receive-notification-events-correctly.patch queue-4.7/i40iw-change-mem_resources-pointer-to-a-u8.patch queue-4.7/i40iw-protect-req_resource_num-update.patch queue-4.7/i40iw-add-missing-null-check-for-mpa-private-data.patch queue-4.7/i40iw-avoid-writing-to-freed-memory.patch queue-4.7/i40iw-do-not-set-self-referencing-pointer-to-null-after-kfree.patch