Skip to contentSkip to conversation

drm/amdgpu: revert "exclude 5dw digest for entry"

PATCH In review Christian König 2 participants 2 messages Oct 5, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: revert "exclude 5dw digest for entry"

From: Christian König <[email protected]>

This commit breaks driver load on a whole bunch of hardware, revert it for now until we know how to do this correctly.

This reverts commit 6691270952b6909218c520dcc71a342070c96874.

---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 2dc4b30..6df0d6e 100644
@@ -372,7 +372,7 @@ static int smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 		entry->image_addr_low = smu_lower_32_bits(info.mc_addr);
 		entry->meta_data_addr_high = 0;
 		entry->meta_data_addr_low = 0;
-		entry->data_size_byte = info.image_size - 20; /* exclude 5dw digest */
+		entry->data_size_byte = info.image_size;
 		entry->num_register_entries = 0;
 	}
 
Signature · 6 lines
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1475658481-1743-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

Reviewed-by
#2 lore raw

That revert works on my FIJI and Tonga test setups.

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Christian König <[email protected]>
Sent: Wednesday, October 5, 2016 05:08
To: [email protected]
Subject: [PATCH] drm/amdgpu: revert "exclude 5dw digest for entry"

From: Christian König <[email protected]>

This commit breaks driver load on a whole bunch of hardware, revert it for now until we know how to do this correctly.

This reverts commit 6691270952b6909218c520dcc71a342070c96874.

---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 2dc4b30..6df0d6e 100644
@@ -372,7 +372,7 @@ static int smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
                 entry->image_addr_low = smu_lower_32_bits(info.mc_addr);
                 entry->meta_data_addr_high = 0;
                 entry->meta_data_addr_low = 0;
-               entry->data_size_byte = info.image_size - 20; /* exclude 5dw digest */
+               entry->data_size_byte = info.image_size;
                 entry->num_register_entries = 0;
         }
 

--
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx