Skip to contentSkip to conversation

Patch "mailbox: mailbox-test: set tdev->signal to NULL after freeing" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Oct 5, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    mailbox: mailbox-test: set tdev->signal to NULL after freeing

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mailbox-mailbox-test-set-tdev-signal-to-null-after-freeing.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9ef3c5112139cc5c5666ee096e05bc1e00e94015 Mon Sep 17 00:00:00 2001

From: Sudeep Holla <[email protected]>
Date: Tue, 24 May 2016 17:12:04 +0100
Subject: mailbox: mailbox-test: set tdev->signal to NULL after freeing

From: Sudeep Holla <[email protected]>

commit 9ef3c5112139cc5c5666ee096e05bc1e00e94015 upstream.

tdev->signal is not set NULL after it's freed. This will cause random exceptions when the stale pointer is accessed after tdev->signal is freed. Also, since tdev->signal allocation is skipped the next time it's written, this leads to continuous fault finally leading to the total death of the system.

Fixes d1c2f87c9a8f ("mailbox: mailbox-test: Prevent memory leak")
---
 drivers/mailbox/mailbox-test.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mailbox/mailbox-test.c +1 -0
@@ -133,6 +133,7 @@ static ssize_t mbox_test_message_write(s
 out:
 	kfree(tdev->signal);
 	kfree(tdev->message);
+	tdev->signal = NULL;
 
 	return ret < 0 ? ret : count;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/arm-dts-imx6sx-sabreauto-fix-misspelled-property.patch queue-4.7/mailbox-mailbox-test-set-tdev-signal-to-null-after-freeing.patch