Skip to contentSkip to conversation

Patch "pstore: drop file opened reference count" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Oct 5, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pstore: drop file opened reference count

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pstore-drop-file-opened-reference-count.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 52d210d961a62a9662e27f14d6505d6741b2fb02 Mon Sep 17 00:00:00 2001

From: Geliang Tang <[email protected]>
Date: Sat, 7 Nov 2015 12:43:49 +0800
Subject: pstore: drop file opened reference count

From: Geliang Tang <[email protected]>

commit 52d210d961a62a9662e27f14d6505d6741b2fb02 upstream.

In ee1d267423a1 ("pstore: add pstore unregister") I added:
.owner = THIS_MODULE,
in both pstore_fs_type and pstore_file_operations to increase a reference count when pstore filesystem is mounted and pstore file is opened.

But, it's repetitive. There is no need to increase the opened reference count. We only need to increase the mounted reference count. When a file is opened, the filesystem can't be unmounted. Hence the pstore module can't be unloaded either.

So I drop the opened reference count in this patch.

Fixes ee1d267423a1 ("pstore: add pstore unregister")
---
 fs/pstore/inode.c |    1 -
 1 file changed, 1 deletion(-)
fs/pstore/inode.c +0 -1
@@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct
 }
 
 static const struct file_operations pstore_file_operations = {
-	.owner		= THIS_MODULE,
 	.open		= pstore_file_open,
 	.read		= pstore_file_read,
 	.llseek		= pstore_file_llseek,

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/pstore-drop-file-opened-reference-count.patch