Skip to contentSkip to conversation

Patch "USB: serial: cp210x: fix hardware flow-control disable" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 6, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    USB: serial: cp210x: fix hardware flow-control disable

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     usb-serial-cp210x-fix-hardware-flow-control-disable.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a377f9e906af4df9071ba8ddba60188cb4013d93 Mon Sep 17 00:00:00 2001

From: Konstantin Shkolnyy <[email protected]>
Date: Wed, 4 May 2016 16:56:52 -0500
Subject: USB: serial: cp210x: fix hardware flow-control disable

From: Konstantin Shkolnyy <[email protected]>

commit a377f9e906af4df9071ba8ddba60188cb4013d93 upstream.

A bug in the CRTSCTS handling caused RTS to alternate between

CRTSCTS=0 => "RTS is transmit active signal" and CRTSCTS=1 => "RTS is used for receive flow control"

instead of

CRTSCTS=0 => "RTS is statically active" and CRTSCTS=1 => "RTS is used for receive flow control"

This only happened after first having enabled CRTSCTS.

Fixes 39a66b8d22a3 ("[PATCH] USB: CP2101 Add support for flow control")
[johan: reword commit message ]
[johan: backport to 4.4 ]

---

This is a backport of an upstream fix to v4.4, which should apply too earlier stable trees as well.

Johan

 drivers/usb/serial/cp210x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/serial/cp210x.c +1 -1
@@ -784,7 +784,7 @@ static void cp210x_set_termios(struct tt
 		} else {
 			modem_ctl[0] &= ~0x7B;
 			modem_ctl[0] |= 0x01;
-			modem_ctl[1] |= 0x40;
+			modem_ctl[1] = 0x40;
 			dev_dbg(dev, "%s - flow control = NONE\n", __func__);
 		}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-cp210x-fix-hardware-flow-control-disable.patch