Skip to contentSkip to conversation

drm/amdgpu: drop atom scratch save/restore in gpu reset

PATCH In review Alex Deucher 2 participants 2 messages Oct 6, 2016 – Oct 9, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: drop atom scratch save/restore in gpu reset

This is already handled by the dce IP modules in their suspend and resume code. No need to do it again.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -4
index 89b3534..ef1d528 100644
@@ -2307,8 +2307,6 @@ int amdgpu_gpu_reset(struct amdgpu_device *adev)
 	}
 
 	if (need_full_reset) {
-		/* save scratch */
-		amdgpu_atombios_scratch_regs_save(adev);
 		r = amdgpu_suspend(adev);
 
 retry:
@@ -2327,8 +2325,6 @@ retry:
 			dev_info(adev->dev, "GPU reset succeeded, trying to resume\n");
 			r = amdgpu_resume(adev);
 		}
-		/* restore scratch */
-		amdgpu_atombios_scratch_regs_restore(adev);
 	}
 	if (!r) {
 		amdgpu_irq_gpu_reset_resume_helper(adev);
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1475767676-10638-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

Am 06.10.2016 um 17:27 schrieb Alex Deucher:

Quoted 4 lines

This is already handled by the dce IP modules in their suspend and resume code. No need to do it again.

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ----
  1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -2
index 89b3534..ef1d528 100644
@@ -2307,8 +2307,6 @@ int amdgpu_gpu_reset(struct amdgpu_device *adev)
  	}
 
  	if (need_full_reset) {
-		/* save scratch */
-		amdgpu_atombios_scratch_regs_save(adev);
  		r = amdgpu_suspend(adev);
 
  retry:

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c retry: · line 2330

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -2
@@ -2327,8 +2325,6 @@ retry:
  			dev_info(adev->dev, "GPU reset succeeded, trying to resume\n");
  			r = amdgpu_resume(adev);
  		}
-		/* restore scratch */
-		amdgpu_atombios_scratch_regs_restore(adev);
  	}
  	if (!r) {
  		amdgpu_irq_gpu_reset_resume_helper(adev);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx