Skip to contentSkip to conversation

sound: soc: cygnus: add depends on HAS_DMA

PATCH Superseded Scott Branden 3 participants 5 messages Oct 7, 2016 – Nov 3, 2016

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound: soc: cygnus: add depends on HAS_DMA

add depends on HAS_DMA to Kconfig. This fixes error reported by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

---
 sound/soc/bcm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/bcm/Kconfig +1 -0
index d528aac..edf3671 100644
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
 config SND_SOC_CYGNUS
 	tristate "SoC platform audio for Broadcom Cygnus chips"
 	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+	depends on HAS_DMA
 	help
 	  Say Y if you want to add support for ASoC audio on Broadcom
 	  Cygnus chips (bcm958300, bcm958305, bcm911360)
Signature · 1 line
2.5.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Scott,

Quoted 14 lines · Scott Branden

add depends on HAS_DMA to Kconfig. This fixes error reported by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

---
  sound/soc/bcm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/bcm/Kconfig +0 -0
index d528aac..edf3671 100644

sound/soc/bcm/Kconfig config SND_BCM2835_SOC_I2S · line 17

Quoted 7 lines
sound/soc/bcm/Kconfig +1 -0
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
  config SND_SOC_CYGNUS
  	tristate "SoC platform audio for Broadcom Cygnus chips"
  	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+	depends on HAS_DMA
  	help
  	  Say Y if you want to add support for ASoC audio on Broadcom
  	  Cygnus chips (bcm958300, bcm958305, bcm911360)

Looks good to me.

#2 lore raw

Hi Takashi/Jaroslav,

Could you pick up this patch?

Quoted 26 lines · Ray Jui

Hi Scott,

Quoted 14 lines · Scott Branden

add depends on HAS_DMA to Kconfig. This fixes error reported by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

---
  sound/soc/bcm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/bcm/Kconfig +0 -0
index d528aac..edf3671 100644

sound/soc/bcm/Kconfig config SND_BCM2835_SOC_I2S · line 17

Quoted 7 lines
sound/soc/bcm/Kconfig +1 -0
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
  config SND_SOC_CYGNUS
      tristate "SoC platform audio for Broadcom Cygnus chips"
      depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+    depends on HAS_DMA
      help
        Say Y if you want to add support for ASoC audio on Broadcom
        Cygnus chips (bcm958300, bcm958305, bcm911360)

Looks good to me.

Quoted 2 lines

Thanks,
Scott

maintainer
#3 lore raw
Quoted 3 lines · Scott Branden

Hi Takashi/Jaroslav,

Could you pick up this patch?

Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.

maintainer
#4 lore raw

Applied "ASoC: bcm: add depends on HAS_DMA" to the asoc tree

In reply to Scott Branden

The patch

ASoC: bcm: add depends on HAS_DMA

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From fe3683779e0b20edf91c549bbff0d81785e1c7a0 Mon Sep 17 00:00:00 2001

From: Scott Branden <[email protected]>
Date: Wed, 2 Nov 2016 13:43:24 -0700
Subject: [PATCH] ASoC: bcm: add depends on HAS_DMA

add depends on HAS_DMA to Kconfig. This fixes error reported by kbuild test robot when building for ARCH=m32r:
ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!

---
 sound/soc/bcm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/bcm/Kconfig +1 -0
index d528aaceaad9..edf367100ebd 100644
@@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
 config SND_SOC_CYGNUS
 	tristate "SoC platform audio for Broadcom Cygnus chips"
 	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
+	depends on HAS_DMA
 	help
 	  Say Y if you want to add support for ASoC audio on Broadcom
 	  Cygnus chips (bcm958300, bcm958305, bcm911360)
Signature · 1 line
2.10.1