Skip to contentSkip to conversation

drm/amdgpu: fix broken VCE startup in phys mode

PATCH In review Christian König 4 participants 4 messages Oct 11, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: fix broken VCE startup in phys mode

From: Christian König <[email protected]>

Add type, align_mask and nop to the physical mode VCE funcs as well.

---
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +3 -0
index f7dbd0d..c7ddbef 100644
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
 };
 
 static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+	.type = AMDGPU_RING_TYPE_VCE,
+	.align_mask = 0xf,
+	.nop = VCE_CMD_NO_OP,
 	.get_rptr = vce_v3_0_ring_get_rptr,
 	.get_wptr = vce_v3_0_ring_get_wptr,
 	.set_wptr = vce_v3_0_ring_set_wptr,
Signature · 6 lines
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1476207217-2210-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#2 lore raw

Yup, with it I get a normal modprobe.

Can add my

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Christian König <[email protected]>
Sent: Tuesday, October 11, 2016 13:33
To: [email protected]
Subject: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

From: Christian König <[email protected]>

Add type, align_mask and nop to the physical mode VCE funcs as well.

---
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +3 -0
index f7dbd0d..c7ddbef 100644
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
 };
 
 static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+       .type = AMDGPU_RING_TYPE_VCE,
+       .align_mask = 0xf,
+       .nop = VCE_CMD_NO_OP,
         .get_rptr = vce_v3_0_ring_get_rptr,
         .get_wptr = vce_v3_0_ring_get_wptr,
         .set_wptr = vce_v3_0_ring_set_wptr,

--
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by Alex Deucher
#3 lore raw
In reply to a message not in the archive
Quoted 7 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Christian König
Sent: Tuesday, October 11, 2016 1:34 PM
To: [email protected]
Subject: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

Quoted 5 lines

From: Christian König <[email protected]>

Add type, align_mask and nop to the physical mode VCE funcs as well.

Please update uvd6 physical mode as well.

Quoted 22 lines
---
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +3 -1
index f7dbd0d..c7ddbef 100644
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
 };
 
 static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+	.type = AMDGPU_RING_TYPE_VCE,
+	.align_mask = 0xf,
+	.nop = VCE_CMD_NO_OP,
 	.get_rptr = vce_v3_0_ring_get_rptr,
 	.get_wptr = vce_v3_0_ring_get_wptr,
 	.set_wptr = vce_v3_0_ring_set_wptr,
--

2.5.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#4 lore raw
In reply to a message not in the archive

I can boot OK with this.

Quoted 15 lines · Christian König

From: Christian König <[email protected]>

Add type, align_mask and nop to the physical mode VCE funcs as well.

---
  drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +0 -0
index f7dbd0d..c7ddbef 100644

drivers/gpu/drm/amd/amdgpu/vce_v3_0.c const struct amd_ip_funcs vce_v3_0_ip_funcs = { · line 837

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +3 -0
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
  };
 
  static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+	.type = AMDGPU_RING_TYPE_VCE,
+	.align_mask = 0xf,
+	.nop = VCE_CMD_NO_OP,
  	.get_rptr = vce_v3_0_ring_get_rptr,
  	.get_wptr = vce_v3_0_ring_get_wptr,
  	.set_wptr = vce_v3_0_ring_set_wptr,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx