staging: bcm2708_vchiq: fix return value check in vchiq_platform_conn_state_changed()

PATCH New Wei Yongjun 1 participant 1 message Oct 17, 2016

Subsystems (2)

Staging Broadcom BCM2711/BCM2835 Arm architecture

lore

Share & tools

lore

Wei Yongjun

author

2016-10-17 15:06 UTC #0 lore raw

PATCH 1/1 staging: bcm2708_vchiq: fix return value check in vchiq_platform_conn_state_changed()

From: Wei Yongjun <[email protected]>

In case of error, the function kthread_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().

Signed-off-by Wei Yongjun <[email protected]>

---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1 -1

index e11c0e0..ccd1735 100644
@@ -2781,7 +2781,7 @@ void vchiq_platform_conn_state_changed(VCHIQ_STATE_T *state,
 				&vchiq_keepalive_thread_func,
 				(void *)state,
 				threadname);
-			if (arm_state->ka_thread == NULL) {
+			if (IS_ERR(arm_state->ka_thread)) {
 				vchiq_log_error(vchiq_susp_log_level,
 					"vchiq: FATAL: couldn't create thread %s",
 					threadname);