Skip to contentSkip to conversation

inotify-tools: add recipe

PATCH In review Andrea Galbusera 2 participants 3 messages Oct 17, 2016 – Oct 18, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 inotify-tools: add recipe

inotify-tools is a C library and a set of command-line programs for Linux providing a simple interface to inotify.

---
 .../inotifywait-fix-compile-error-with-GCC-6.patch | 45 ++++++++++++++++++++++
 .../inotify-tools/inotify-tools_git.bb             | 23 +++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch
 create mode 100644 meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +45 -0
new file mode 100644
index 0000000..ba042a2
@@ -0,0 +1,45 @@
+From 7affb288d6c0726e7b1ebc317a878927b6ef0d02 Mon Sep 17 00:00:00 2001
+From: Andrea Galbusera <[email protected]>
+Date: Tue, 13 Sep 2016 08:10:29 +0200
+Subject: [PATCH] inotifywait: fix compile error with GCC 6
+
+Fails to compile with misleading-indentation error
+
+| src/inotifywait.c: In function 'output_event_csv':
+| src/inotifywait.c:126:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
+|      if (filename != NULL)
+|      ^~
+| src/inotifywait.c:129:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
+|   printf("%s,", csv_escape( inotifytools_event_to_str( event->mask ) ) );
+|   ^~~~~~
+| cc1: all warnings being treated as errors
+
+Fix indentation to resolve.
+
+Upstream-Status: Submitted [https://github.com/rvoicilas/inotify-tools/pull/66]
+
+Signed-off-by: Andrea Galbusera <[email protected]>
+---
+ src/inotifywait.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/inotifywait.c b/src/inotifywait.c
+index c5ce5e3..404a85b 100644
+--- a/src/inotifywait.c
++++ b/src/inotifywait.c
+@@ -122,9 +122,9 @@ void validate_format( char * fmt ) {
+ 
+ 
+ void output_event_csv( struct inotify_event * event ) {
+-    char *filename = csv_escape(inotifytools_filename_from_wd(event->wd));
+-    if (filename != NULL)
+-        printf("%s,", filename);
++	char *filename = csv_escape(inotifytools_filename_from_wd(event->wd));
++	if (filename != NULL)
++		printf("%s,", filename);
+ 
+ 	printf("%s,", csv_escape( inotifytools_event_to_str( event->mask ) ) );
+ 	if ( event->len > 0 )
+-- 
+1.9.1
+
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +23 -0
new file mode 100644
index 0000000..a8ef557
@@ -0,0 +1,23 @@
+SUMMARY = "Command line tools and C library providing a simple interface to inotify"
+AUTHOR = "Rohan McGovern <[email protected]>"
+HOMEPAGE = "http://wiki.github.com/rvoicilas/inotify-tools"
+SECTION = "console/devel"
+LICENSE = "GPL-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=ac6c26e52aea428ee7f56dc2c56424c6"
+
+SRCREV = "1df9af4d6cd0f4af4b1b19254bcf056aed4ae395"
+PV = "3.14+git${SRCPV}"
+
+SRC_URI = "git://github.com/rvoicilas/${BPN} \
+           file://inotifywait-fix-compile-error-with-GCC-6.patch \
+          "
+
+S = "${WORKDIR}/git"
+
+inherit autotools
+
+EXTRA_OECONF = "--disable-doxygen"
+
+PACKAGES =+ "libinotifytools"
+
+FILES_libinotifytools = "${libdir}/lib*.so.*"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Andrea Galbusera

inotify-tools is a C library and a set of command-line programs for Linux providing a simple interface to inotify.

---
 .../inotifywait-fix-compile-error-with-GCC-6.patch | 45

++++++++++++++++++++++

Quoted 3 lines
 .../inotify-tools/inotify-tools_git.bb             | 23 +++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 1 line
 create mode 100644 meta-oe/recipes-support/inotify-tools/

inotify-tools_git.bb

Quoted 2 lines

diff --git

a/meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch b/meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 4 lines

new file mode 100644
index 0000000..ba042a2
--- /dev/null
+++

b/meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch line 9

Quoted 10 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +9 -0
@@ -0,0 +1,45 @@
+From 7affb288d6c0726e7b1ebc317a878927b6ef0d02 Mon Sep 17 00:00:00 2001
+From: Andrea Galbusera <[email protected]>
+Date: Tue, 13 Sep 2016 08:10:29 +0200
+Subject: [PATCH] inotifywait: fix compile error with GCC 6
+
+Fails to compile with misleading-indentation error
+
+| src/inotifywait.c: In function 'output_event_csv':
+| src/inotifywait.c:126:5: error: this 'if' clause does not guard...

[-Werror=misleading-indentation]

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 3 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +3 -0
+|      if (filename != NULL)
+|      ^~
+| src/inotifywait.c:129:2: note: ...this statement, but the latter is

misleadingly indented as if it is guarded by the 'if'

Review line 13

Quoted 1 line
(quoted diff) +1 -0
+|   printf("%s,", csv_escape( inotifytools_event_to_str( event->mask ) )

);

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 6 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +6 -0
+|   ^~~~~~
+| cc1: all warnings being treated as errors
+
+Fix indentation to resolve.
+
+Upstream-Status: Submitted [

https://github.com/rvoicilas/inotify-tools/pull/66]

Quoted 5 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +5 -0
+
+Signed-off-by: Andrea Galbusera <[email protected]>
+---
+ src/inotifywait.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 10 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +10 -0
+
+diff --git a/src/inotifywait.c b/src/inotifywait.c
+index c5ce5e3..404a85b 100644
+--- a/src/inotifywait.c
++++ b/src/inotifywait.c
+@@ -122,9 +122,9 @@ void validate_format( char * fmt ) {
+
+
+ void output_event_csv( struct inotify_event * event ) {
+-    char *filename =

csv_escape(inotifytools_filename_from_wd(event->wd));

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 3 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +3 -0
+-    if (filename != NULL)
+-        printf("%s,", filename);
++      char *filename =

csv_escape(inotifytools_filename_from_wd(event->wd));

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 4 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +4 -0
++      if (filename != NULL)
++              printf("%s,", filename);
+
+       printf("%s,", csv_escape( inotifytools_event_to_str( event->mask

) ) );

Review

Quoted 5 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +4 -0
+       if ( event->len > 0 )
+--
+1.9.1
+
(quoted diff) +0 -0

b/meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb line 1

Quoted 6 lines

new file mode 100644
index 0000000..a8ef557

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +1 -0
@@ -0,0 +1,23 @@
+SUMMARY = "Command line tools and C library providing a simple interface

to inotify"

Quoted 11 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +10 -0
+AUTHOR = "Rohan McGovern <[email protected]>"
+HOMEPAGE = "http://wiki.github.com/rvoicilas/inotify-tools"
+SECTION = "console/devel"
+LICENSE = "GPL-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=ac6c26e52aea428ee7f56dc2c56424c6"
+
+SRCREV = "1df9af4d6cd0f4af4b1b19254bcf056aed4ae395"
+PV = "3.14+git${SRCPV}"
+
+SRC_URI = "git://github.com/rvoicilas/${BPN} \

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb line 21

Quoted 10 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +10 -0
+           file://inotifywait-fix-compile-error-with-GCC-6.patch \
+          "
+
+S = "${WORKDIR}/git"
+
+inherit autotools
+
+EXTRA_OECONF = "--disable-doxygen"
+
+PACKAGES =+ "libinotifytools"

Why is this needed ?

Quoted 9 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +1 -1
+FILES_libinotifytools = "${libdir}/lib*.so.*"
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Hi Khem,

Quoted 105 lines · Khem Raj
Quoted 7 lines · Andrea Galbusera

inotify-tools is a C library and a set of command-line programs for Linux providing a simple interface to inotify.

---
 .../inotifywait-fix-compile-error-with-GCC-6.patch | 45

++++++++++++++++++++++

Quoted 3 lines
 .../inotify-tools/inotify-tools_git.bb             | 23 +++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644

meta-oe/recipes-support/inotify-tools/inotify-tools/ inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 1 line
 create mode 100644 meta-oe/recipes-support/inotify-tools/

inotify-tools_git.bb

Quoted 2 lines

diff --git

a/meta-oe/recipes-support/inotify-tools/inotify-tools/ inotifywait-fix-compile-error-with-GCC-6.patch b/meta-oe/recipes-support/inotify-tools/inotify-tools/ inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 4 lines

new file mode 100644
index 0000000..ba042a2
--- /dev/null
+++

b/meta-oe/recipes-support/inotify-tools/inotify-tools/ inotifywait-fix-compile-error-with-GCC-6.patch

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch line 9

Quoted 10 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +9 -0
@@ -0,0 +1,45 @@
+From 7affb288d6c0726e7b1ebc317a878927b6ef0d02 Mon Sep 17 00:00:00 2001
+From: Andrea Galbusera <[email protected]>
+Date: Tue, 13 Sep 2016 08:10:29 +0200
+Subject: [PATCH] inotifywait: fix compile error with GCC 6
+
+Fails to compile with misleading-indentation error
+
+| src/inotifywait.c: In function 'output_event_csv':
+| src/inotifywait.c:126:5: error: this 'if' clause does not guard...

[-Werror=misleading-indentation]

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 3 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +3 -0
+|      if (filename != NULL)
+|      ^~
+| src/inotifywait.c:129:2: note: ...this statement, but the latter is

misleadingly indented as if it is guarded by the 'if'

Review line 13

Quoted 1 line
(quoted diff) +1 -0
+|   printf("%s,", csv_escape( inotifytools_event_to_str( event->mask ) )

);

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 6 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +6 -0
+|   ^~~~~~
+| cc1: all warnings being treated as errors
+
+Fix indentation to resolve.
+
+Upstream-Status: Submitted [

https://github.com/rvoicilas/inotify-tools/pull/66]

Quoted 5 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +5 -0
+
+Signed-off-by: Andrea Galbusera <[email protected]>
+---
+ src/inotifywait.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 10 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +10 -0
+
+diff --git a/src/inotifywait.c b/src/inotifywait.c
+index c5ce5e3..404a85b 100644
+--- a/src/inotifywait.c
++++ b/src/inotifywait.c
+@@ -122,9 +122,9 @@ void validate_format( char * fmt ) {
+
+
+ void output_event_csv( struct inotify_event * event ) {
+-    char *filename =

csv_escape(inotifytools_filename_from_wd(event->wd));

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 3 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +3 -0
+-    if (filename != NULL)
+-        printf("%s,", filename);
++      char *filename =

csv_escape(inotifytools_filename_from_wd(event->wd));

meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch

Quoted 4 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +4 -0
++      if (filename != NULL)
++              printf("%s,", filename);
+
+       printf("%s,", csv_escape( inotifytools_event_to_str( event->mask

) ) );

Review

Quoted 5 lines
meta-oe/recipes-support/inotify-tools/inotify-tools/inotifywait-fix-compile-error-with-GCC-6.patch new file +4 -0
+       if ( event->len > 0 )
+--
+1.9.1
+
(quoted diff) +0 -0

b/meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb line 1

Quoted 6 lines

new file mode 100644
index 0000000..a8ef557

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +1 -0
@@ -0,0 +1,23 @@
+SUMMARY = "Command line tools and C library providing a simple interface

to inotify"

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb

Quoted 5 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +5 -0
+AUTHOR = "Rohan McGovern <[email protected]>"
+HOMEPAGE = "http://wiki.github.com/rvoicilas/inotify-tools"
+SECTION = "console/devel"
+LICENSE = "GPL-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=ac6c26e52aea428ee7f56dc2c56424

c6"

Quoted 9 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +9 -0
+
+SRCREV = "1df9af4d6cd0f4af4b1b19254bcf056aed4ae395"
+PV = "3.14+git${SRCPV}"
+
+SRC_URI = "git://github.com/rvoicilas/${BPN} \
+           file://inotifywait-fix-compile-error-with-GCC-6.patch \
+          "
+
+S = "${WORKDIR}/git"
Quoted 8 lines

meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb line 21

Quoted 7 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +6 -0
+
+inherit autotools
+
+EXTRA_OECONF = "--disable-doxygen"
+
+PACKAGES =+ "libinotifytools"

Why is this needed ?

The upstream project provides a thin C library and a couple of tools, inotify{watch,wait}, built on to top of it. This was intended as an improvement to the default packaging, to allow using and installing the library for your own developments. The approach is inspired by i.e. curl/libcurl recipe.

Quoted 20 lines
Quoted 9 lines
meta-oe/recipes-support/inotify-tools/inotify-tools_git.bb new file +1 -1
+FILES_libinotifytools = "${libdir}/lib*.so.*"
--

1.9.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel