Skip to contentSkip to conversation

drm/amdgpu/st: move ATC CG golden init from gfx to mc

PATCH In review Alex Deucher 2 participants 2 messages Oct 18, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/st: move ATC CG golden init from gfx to mc

It's technically an MC register so make sure we initialize it in the MC module rather than the gfx module. Since other bits in the same register are used to enable ATC CG features make sure we apply the golden setting first.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 -
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +0 -1
index 1c2544f..6ce44bf 100644
@@ -640,7 +640,6 @@ static const u32 stoney_mgcg_cgcg_init[] =
 	mmCP_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
 	mmRLC_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
 	mmCGTS_SM_CTRL_REG, 0xffffffff, 0x96940200,
-	mmATC_MISC_CG, 0xffffffff, 0x000c0200,
 };
 
 static void gfx_v8_0_set_ring_funcs(struct amdgpu_device *adev);
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +1 -0
index 74d7cc3..f7372d3 100644
@@ -100,6 +100,7 @@ static const u32 cz_mgcg_cgcg_init[] =
 
 static const u32 stoney_mgcg_cgcg_init[] =
 {
+	mmATC_MISC_CG, 0xffffffff, 0x000c0200,
 	mmMC_MEM_POWER_LS, 0xffffffff, 0x00000104
 };
 
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1476765276-11866-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

Am 18.10.2016 um 06:34 schrieb Alex Deucher:

Quoted 6 lines

It's technically an MC register so make sure we initialize it in the MC module rather than the gfx module. Since other bits in the same register are used to enable ATC CG features make sure we apply the golden setting first.

Quoted 22 lines
---
  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 -
  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 +
  2 files changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +0 -1
index 1c2544f..6ce44bf 100644
@@ -640,7 +640,6 @@ static const u32 stoney_mgcg_cgcg_init[] =
  	mmCP_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
  	mmRLC_MEM_SLP_CNTL, 0xffffffff, 0x00020201,
  	mmCGTS_SM_CTRL_REG, 0xffffffff, 0x96940200,
-	mmATC_MISC_CG, 0xffffffff, 0x000c0200,
  };
 
  static void gfx_v8_0_set_ring_funcs(struct amdgpu_device *adev);
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +0 -0
index 74d7cc3..f7372d3 100644

drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c static const u32 cz_mgcg_cgcg_init[] = · line 106

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +1 -0
@@ -100,6 +100,7 @@ static const u32 cz_mgcg_cgcg_init[] =
 
  static const u32 stoney_mgcg_cgcg_init[] =
  {
+	mmATC_MISC_CG, 0xffffffff, 0x000c0200,
  	mmMC_MEM_POWER_LS, 0xffffffff, 0x00000104
  };
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx