Skip to contentSkip to conversation

drm: make is_lspcon_adaptor static

PATCH In review Jani Nikula 3 participants 6 messages Oct 18, 2016 – Oct 19, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm: make is_lspcon_adaptor static

Fixes sparse warning:

drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?

Fixes 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc Rodrigo Vivi <[email protected]>
Cc Shashank Sharma <[email protected]>

---

n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree

---
 drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_dual_mode_helper.c +2 -2
index a7aeb1ec852c..2624e266abbd 100644
@@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
 			      DP_DUAL_MODE_REV_TYPE2);
 }
 
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
-	const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
+			      const uint8_t adaptor_id)
 {
 	return is_hdmi_adaptor(hdmi_id) &&
 		(adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915: make lspcon_get_current_mode static

Fixes sparse warning:

drivers/gpu/drm/i915/intel_lspcon.c:30:22: warning: symbol 'lspcon_get_current_mode' was not declared. Should it be static?

Fixes dbe9e61b8e43 ("drm/i915: Add lspcon support for I915 driver")
Cc Rodrigo Vivi <[email protected]>
Cc Shashank Sharma <[email protected]>
---
 drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lspcon.c +1 -1
index d606f1a8f3b6..632149c6b3ad 100644
@@ -27,7 +27,7 @@
 #include <drm/drm_dp_dual_mode_helper.h>
 #include "intel_drv.h"
 
-enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
+static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
 {
 	enum drm_lspcon_mode current_mode = DRM_LSPCON_MODE_INVALID;
 	struct i2c_adapter *adapter = &lspcon->aux->ddc;
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by Shashank Sharma on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/i915: make lspcon_get_current_mode static

Reviewed-by Shashank Sharma

Regards
Shashank
-----Original Message-----
From: Nikula, Jani
Sent: Tuesday, October 18, 2016 4:52 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Vivi, Rodrigo <[email protected]>; Sharma, Shashank <[email protected]>
Subject: [PATCH 2/2] drm/i915: make lspcon_get_current_mode static

Fixes sparse warning:

drivers/gpu/drm/i915/intel_lspcon.c:30:22: warning: symbol 'lspcon_get_current_mode' was not declared. Should it be static?

Fixes dbe9e61b8e43 ("drm/i915: Add lspcon support for I915 driver")
Cc Rodrigo Vivi <[email protected]>
Cc Shashank Sharma <[email protected]>
---
 drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lspcon.c +2 -2
index d606f1a8f3b6..632149c6b3ad 100644
@@ -27,7 +27,7 @@
 #include <drm/drm_dp_dual_mode_helper.h>  #include "intel_drv.h"
 
-enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
+static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon 
+*lspcon)
 {
 	enum drm_lspcon_mode current_mode = DRM_LSPCON_MODE_INVALID;
 	struct i2c_adapter *adapter = &lspcon->aux->ddc;
--

2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by Shashank Sharma on v1 1/2
#3 lore raw
In reply to Jani Nikula
Reviewed-by Shashank Sharma

Regards
Shashank
-----Original Message-----
From: Nikula, Jani
Sent: Tuesday, October 18, 2016 4:52 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Vivi, Rodrigo <[email protected]>; Sharma, Shashank <[email protected]>; [email protected]
Subject: [PATCH 1/2] drm: make is_lspcon_adaptor static

Fixes sparse warning:

drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?

Fixes 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc Rodrigo Vivi <[email protected]>
Cc Shashank Sharma <[email protected]>

---

n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree

---
 drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_dual_mode_helper.c +2 -2
index a7aeb1ec852c..2624e266abbd 100644
@@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
 			      DP_DUAL_MODE_REV_TYPE2);
 }
 
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
-	const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
+			      const uint8_t adaptor_id)
 {
 	return is_hdmi_adaptor(hdmi_id) &&
 		(adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |

--
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 1 line · Shashank
Reviewed-by Shashank Sharma

Both pushed to drm-intel-next-queued, thanks for the review.

RB,
Jani.

Quoted 45 lines

Regards
Shashank
-----Original Message-----
From: Nikula, Jani
Sent: Tuesday, October 18, 2016 4:52 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Vivi, Rodrigo <[email protected]>; Sharma, Shashank <[email protected]>; [email protected]
Subject: [PATCH 1/2] drm: make is_lspcon_adaptor static

Fixes sparse warning:

drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static?

Fixes 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode")
Cc Rodrigo Vivi <[email protected]>
Cc Shashank Sharma <[email protected]>

---

n.b. 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") has been merged via drm-intel tree

---
 drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_dual_mode_helper.c +2 -3
index a7aeb1ec852c..2624e266abbd 100644
@@ -148,8 +148,8 @@ static bool is_type2_adaptor(uint8_t adaptor_id)
 			      DP_DUAL_MODE_REV_TYPE2);
 }
 
-bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
-	const uint8_t adaptor_id)
+static bool is_lspcon_adaptor(const char hdmi_id[DP_DUAL_MODE_HDMI_ID_LEN],
+			      const uint8_t adaptor_id)
 {
 	return is_hdmi_adaptor(hdmi_id) &&
 		(adaptor_id == (DP_DUAL_MODE_TYPE_TYPE2 |
--

2.1.4

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw

✗ Fi.CI.BAT: failure for series starting with [1/2] drm: make is_lspcon_adaptor static

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm: make is_lspcon_adaptor static
URL : https://patchwork.freedesktop.org/series/13944/
State : failure

== Summary ==

Series 13944v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/13944/revisions/1/mbox/

Test gem_exec_suspend:

        Subgroup basic-s3:
                pass       -> INCOMPLETE (fi-ivb-3770)
Test gem_sync:
        Subgroup basic-store-each:
                pass       -> FAIL       (fi-ivb-3520m)
Test vgem_basic:
        Subgroup unload:
                skip       -> PASS       (fi-bdw-5557u)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:203  dwarn:1   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:76   pass:62   dwarn:0   dfail:0   fail:1   skip:12 
fi-byt-n2820     total:246  pass:209  dwarn:1   dfail:0   fail:1   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:223  dwarn:1   dfail:0   fail:0   skip:22 
fi-ilk-650       total:246  pass:181  dwarn:0   dfail:0   fail:5   skip:60 
fi-ivb-3520m     total:246  pass:220  dwarn:0   dfail:0   fail:1   skip:25 
fi-ivb-3770      total:76   pass:63   dwarn:0   dfail:0   fail:0   skip:12 
fi-kbl-7200u     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-skl-6700hq    total:246  pass:219  dwarn:4   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24 
fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36 
fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_2742/

7cdf5d9e9e8e0e0fdf3034f949f72a6d64783f6c drm-intel-nightly: 2016y-10m-18d-10h-27m-08s UTC integration manifest 84c7054 drm/i915: make lspcon_get_current_mode static
1eccec0 drm: make is_lspcon_adaptor static

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx