drm: fix sparse warnings on undeclared symbols in crc debugfs
Subsystems (2)
PATCH 1/1 drm: fix sparse warnings on undeclared symbols in crc debugfs
Fixes sparse warnings:
drivers/gpu/drm/drm_debugfs_crc.c:118:30: warning: symbol 'drm_crtc_crc_control_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:264:30: warning: symbol 'drm_crtc_crc_data_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:281:5: warning: symbol 'drm_debugfs_crtc_crc_add' was not declared. Should it be static?
--- drivers/gpu/drm/drm_debugfs_crc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_debugfs_crc.c +3 -2
@@ -30,6 +30,7 @@#include <linux/ctype.h> #include <linux/debugfs.h> #include <drm/drmP.h> +#include "drm_internal.h" /** * DOC: CRC ABI
@@ -115,7 +116,7 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,return len; } -const struct file_operations drm_crtc_crc_control_fops = { +static const struct file_operations drm_crtc_crc_control_fops = { .owner =THIS_MODULE , .open = crc_control_open, .read = seq_read,
@@ -261,7 +262,7 @@ static ssize_t crtc_crc_read(struct file *filep, char __user *user_buf,return LINE_LEN (crc->values_cnt); } -const struct file_operations drm_crtc_crc_data_fops = { +static const struct file_operations drm_crtc_crc_data_fops = { .owner =THIS_MODULE , .open = crtc_crc_open, .read = crtc_crc_read,
Signature · 6 lines
2.1.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 11 lines · Jani Nikula
Fixes sparse warnings:
drivers/gpu/drm/drm_debugfs_crc.c:118:30: warning: symbol 'drm_crtc_crc_control_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:264:30: warning: symbol 'drm_crtc_crc_data_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:281:5: warning: symbol 'drm_debugfs_crtc_crc_add' was not declared. Should it be static?
Quoted 6 lines
Fixes 9edbf1fa600a ("drm: Add API for capturing frame CRCs")Cc Benjamin Gaignard <[email protected]>Cc Daniel Vetter <[email protected]>Cc Emil Velikov <[email protected]>Cc Tomeu Vizoso <[email protected]>Signed-off-by Jani Nikula <[email protected]>
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula
AppliedQuoted 12 lines · Chris Wilson
Quoted 11 lines · Jani Nikula
Fixes sparse warnings:
drivers/gpu/drm/drm_debugfs_crc.c:118:30: warning: symbol 'drm_crtc_crc_control_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:264:30: warning: symbol 'drm_crtc_crc_data_fops' was not declared. Should it be static?
drivers/gpu/drm/drm_debugfs_crc.c:281:5: warning: symbol 'drm_debugfs_crtc_crc_add' was not declared. Should it be static?
Quoted 7 lines
Quoted 6 lines
Fixes 9edbf1fa600a ("drm: Add API for capturing frame CRCs")Cc Benjamin Gaignard <[email protected]>Cc Daniel Vetter <[email protected]>Cc Emil Velikov <[email protected]>Cc Tomeu Vizoso <[email protected]>Signed-off-by Jani Nikula <[email protected]>Reviewed-by Chris Wilson <[email protected]>
Pushed to drm-misc, thanks for the review.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✗ Fi.CI.BAT: failure for drm: fix sparse warnings on undeclared symbols in crc debugfs
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm: fix sparse warnings on undeclared symbols in crc debugfs
URL : https://patchwork.freedesktop.org/series/13948/
State : failure
== Summary ==
Series 13948v1 drm: fix sparse warnings on undeclared symbols in crc debugfs
https://patchwork.freedesktop.org/api/1.0/series/13948/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> DMESG-WARN (fi-skl-6700hq)
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-skl-6700hq)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-skl-6700hq)
pass -> INCOMPLETE (fi-bdw-5557u)
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-c:
dmesg-warn -> PASS (fi-skl-6700hq)
Test vgem_basic:
Subgroup unload:
skip -> PASS (fi-kbl-7200u)fi-bdw-5557u total:208 pass:194 dwarn:0 dfail:0 fail:0 skip:13 fi-bsw-n3050 total:246 pass:203 dwarn:1 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30 fi-byt-j1900 total:76 pass:62 dwarn:0 dfail:0 fail:1 skip:12 fi-byt-n2820 total:246 pass:209 dwarn:1 dfail:0 fail:1 skip:35 fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:246 pass:223 dwarn:1 dfail:0 fail:0 skip:22 fi-ilk-650 total:246 pass:181 dwarn:0 dfail:0 fail:5 skip:60 fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24 fi-skl-6700hq total:246 pass:222 dwarn:1 dfail:0 fail:0 skip:23 fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24 fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2743/
7cdf5d9e9e8e0e0fdf3034f949f72a6d64783f6c drm-intel-nightly: 2016y-10m-18d-10h-27m-08s UTC integration manifest
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx