Skip to contentSkip to conversation

Patch "ext4: enforce online defrag restriction for encrypted files" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Oct 20, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ext4: enforce online defrag restriction for encrypted files

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ext4-enforce-online-defrag-restriction-for-encrypted-files.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 14fbd4aa613bd5110556c281799ce36dc6f3ba97 Mon Sep 17 00:00:00 2001

From: Eric Whitney <[email protected]>
Date: Mon, 29 Aug 2016 15:45:11 -0400
Subject: ext4: enforce online defrag restriction for encrypted files

From: Eric Whitney <[email protected]>

commit 14fbd4aa613bd5110556c281799ce36dc6f3ba97 upstream.

Online defragging of encrypted files is not currently implemented. However, the move extent ioctl can still return successfully when called. For example, this occurs when xfstest ext4/020 is run on an encrypted file system, resulting in a corrupted test file and a corresponding test failure.

Until the proper functionality is implemented, fail the move extent ioctl if either the original or donor file is encrypted.

---
 fs/ext4/move_extent.c |    7 +++++++
 1 file changed, 7 insertions(+)
fs/ext4/move_extent.c +7 -0
@@ -598,6 +598,13 @@ ext4_move_extents(struct file *o_filp, s
 		return -EOPNOTSUPP;
 	}
 
+	if (ext4_encrypted_inode(orig_inode) ||
+	    ext4_encrypted_inode(donor_inode)) {
+		ext4_msg(orig_inode->i_sb, KERN_ERR,
+			 "Online defrag not supported for encrypted files");
+		return -EOPNOTSUPP;
+	}
+
 	/* Protect orig and donor inodes against a truncate */
 	lock_two_nondirectories(orig_inode, donor_inode);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/ext4-enforce-online-defrag-restriction-for-encrypted-files.patch