kexec: Increase the upper limit for RAM segments
Subsystems (2)
PATCH 1/1 kexec: Increase the upper limit for RAM segments
Change the current hardcoded values to 64 from 16.
--- kexec/arch/arm64/kexec-arm64.h | 2 +- kexec/kexec-syscall.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
kexec/arch/arm64/kexec-arm64.h +1 -1
@@ -11,7 +11,7 @@#include "image-header.h" #include "kexec.h" -#define KEXEC_SEGMENT_MAX 16 +#define KEXEC_SEGMENT_MAX 64#define BOOT_BLOCK_VERSION 17#define BOOT_BLOCK_LAST_COMP_VERSION 16
kexec/kexec-syscall.h +1 -1
@@ -115,7 +115,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd,#define KEXEC_ARCH_MIPS ( 8 << 16)#define KEXEC_ARCH_CRIS (76 << 16) -#define KEXEC_MAX_SEGMENTS 16 +#define KEXEC_MAX_SEGMENTS 64#ifdef __i386__#define KEXEC_ARCH_NATIVE KEXEC_ARCH_386
Signature · 7 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Hi Sameer.
Quoted 1 line · Sameer Goel
Change the current hardcoded values to 64 from 16.
Please add an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
This change is needed in case when the System Ram listings are retrieved from /proc/iomem. On a newer UEFI based Qualcomm system, the number of regions listed were close to 34. So, the actual system ram region was not covered and the kexec tool failed to load the kernel image.
So, I have requested an increase in the number of memory regions. Thanks,
Sameer
Quoted 14 lines · Geoff Levand
Hi Sameer.
Quoted 1 line · Sameer Goel
Change the current hardcoded values to 64 from 16.
Please add an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Signature · 8 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 7 lines · Sameer
This change is needed in case when the System Ram listings are retrieved from
/proc/iomem. On a newer UEFI based Qualcomm system, the number of regions listed were close to 34. So, the actual system ram region was not covered and the kexec tool failed to load the kernel image.So, I have requested an increase in the number of memory regions. Thanks,
It would be great to add this to your patch log so that reviewers can understand it better. Better repost with an updated patch log, copying these as patch log is good enough.
Quoted 10 lines
Sameer
Quoted 7 lines · Geoff Levand
Hi Sameer.
Quoted 1 line · Sameer Goel
Change the current hardcoded values to 64 from 16.
Please add an explanation of why this change is needed.
Quoted 17 lines
Quoted 7 lines
-Geoff
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexecSignature · 8 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Hi Sameer,
Quoted 13 lines · Sameer
This change is needed in case when the System Ram listings are retrieved from
/proc/iomem. On a newer UEFI based Qualcomm system, the number of regions listed were close to 34. So, the actual system ram region was not covered and the kexec tool failed to load the kernel image.So, I have requested an increase in the number of memory regions. Thanks,
SameerQuoted 6 lines · Geoff Levand
Hi Sameer.
Quoted 1 line · Sameer Goel
Change the current hardcoded values to 64 from 16.
Please add an explanation of why this change is needed.
Sorry I wasn't clear. Please post a new patch, and in the commit log include an explanation of why this change is needed.
-Geoff
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec