patch "USB: serial: cp210x: fix tiocmget error handling" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: cp210x: fix tiocmget error handling
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
de24e0a108bc48062e1c7acaa97014bce32a919fMon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Wed, 19 Oct 2016 15:45:07 +0200
Subject: USB: serial: cp210x: fix tiocmget error handling
The current tiocmget implementation would fail to report errors up the stack and instead leaked a few bits from the stack as a mask of modem-status flags.
--- drivers/usb/serial/cp210x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/serial/cp210x.c +3 -1
@@ -1077,7 +1077,9 @@ static int cp210x_tiocmget(struct tty_struct *tty)u8 control;int result; -cp210x_read_u8_reg (port,CP210X_GET_MDMSTS , &control); + result =cp210x_read_u8_reg (port,CP210X_GET_MDMSTS , &control); +if (result) +return result; result = ((control &CONTROL_DTR ) ?TIOCM_DTR :0 ) |((control &CONTROL_RTS ) ?TIOCM_RTS :0 )
Signature · 1 line
2.10.1