drm/amdgpu: fix a vm_flush fence leak
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix a vm_flush fence leak
Looks like .last_flush reference is left at teardown. Leak reported by CONFIG_SLUB_DEBUG.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1 -0
@@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)fence_put (adev->vm_manager.ids[i].first);amdgpu_sync_free (&adev->vm_manager.ids[i].active);fence_put (id->flushed_updates); +fence_put (id->last_flush); } }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1477247507-11378-3-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
zhoucm1
Reviewed-by Chunming ZhouQuoted 5 lines · Grazvydas Ignotas
Looks like .last_flush reference is left at teardown. Leak reported by
CONFIG_SLUB_DEBUG.Fixes 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")Signed-off-by Grazvydas Ignotas <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c void amdgpu_vm_manager_fini(struct amdgpu_device *adev) · line 1779
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-0@@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)fence_put (adev->vm_manager.ids[i].first);amdgpu_sync_free (&adev->vm_manager.ids[i].active);fence_put (id->flushed_updates); +fence_put (id->last_flush); } }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Christian König
Reviewed-byAm 24.10.2016 um 04:32 schrieb zhoucm1:
Quoted 9 lines · Grazvydas Ignotas
Quoted 5 lines
Looks like .last_flush reference is left at teardown. Leak reported by
CONFIG_SLUB_DEBUG.Fixes 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")Signed-off-by Grazvydas Ignotas <[email protected]>Reviewed-by Chunming Zhou <[email protected]>
Quoted 13 lines
Quoted 13 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0
-0@@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev) fence_put(adev->vm_manager.ids[i].first);amdgpu_sync_free (&adev->vm_manager.ids[i].active);fence_put (id->flushed_updates);
Quoted 8 lines
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-0+fence_put (id->last_flush); }}_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedQuoted 21 lines · Christian König
Am 24.10.2016 um 04:32 schrieb zhoucm1:
Quoted 12 lines · Grazvydas Ignotas
Quoted 6 lines
Looks like .last_flush reference is left at teardown. Leak reported by
CONFIG_SLUB_DEBUG.Fixes 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")Signed-off-by Grazvydas Ignotas <[email protected]>Reviewed-by Chunming Zhou <[email protected]>Reviewed-by Christian König <[email protected]>.Quoted 4 lines
Quoted 4 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0
-0Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +1
-0@@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device *adev)fence_put (adev->vm_manager.ids[i].first);amdgpu_sync_free (&adev->vm_manager.ids[i].active);fence_put (id->flushed_updates); +fence_put (id->last_flush); }}
Applied. Thanks!
Alex
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel