Patch "spi: spidev_test: Fix buffer overflow in unescape()" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
spi: spidev_test: Fix buffer overflow in unescape()
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
spi-spidev_test-fix-buffer-overflow-in-unescape.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
0278b34bf15f8d8a609595b15909cd8622dd64caMon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <[email protected]>
Date: Fri, 9 Sep 2016 09:02:51 +0200
Subject: spi: spidev_test: Fix buffer overflow in unescape()
From: Geert Uytterhoeven <[email protected]>
commit 0278b34bf15f8d8a609595b15909cd8622dd64ca upstream.
Sometimes spidev_test crashes with:
*** Error in `spidev_test': munmap_chunk(): invalid pointer: 0x00022020 ***
Abortedor just
Segmentation fault
This is due to transfer_escaped_string() miscalculating the required size of the buffer by one byte, causing a buffer overflow in unescape().
Drop the bogus "+ 1" in the strlen() parameter to fix this.
Note that unescape() never copies the zero-terminator of the source string, so it writes at most as many bytes as the length of the source string.
--- tools/spi/spidev_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/spi/spidev_test.c +1 -1
@@ -284,7 +284,7 @@ static void parse_opts(int argc, char *astatic void transfer_escaped_string (int fd,char *str) { -size_t size =strlen (str +1 ); +size_t size =strlen (str);uint8_t *tx;uint8_t *rx;
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/spi-spidev_test-fix-buffer-overflow-in-unescape.patch