Skip to contentSkip to conversation

Patch "PCI: tegra: Fix argument order in tegra_pcie_phy_disable()" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 25, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

PCI: tegra: Fix argument order in tegra_pcie_phy_disable()

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pci-tegra-fix-argument-order-in-tegra_pcie_phy_disable.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8dd99bca7bfa4b62753b556c45d26f45ec9da6e6 Mon Sep 17 00:00:00 2001

From: Bjorn Helgaas <[email protected]>
Date: Wed, 5 Oct 2016 16:04:13 -0500
Subject: PCI: tegra: Fix argument order in tegra_pcie_phy_disable()

From: Bjorn Helgaas <[email protected]>

commit 8dd99bca7bfa4b62753b556c45d26f45ec9da6e6 upstream.

The tegra_pcie_phy_disable() path called pads_writel() with arguments in the wrong order. Swap them to be the "value, offset" order expected by pads_writel().

Fixes 6fe7c187e026 ("PCI: tegra: Support per-lane PHYs")
---
 drivers/pci/host/pci-tegra.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-tegra.c +1 -1
@@ -856,7 +856,7 @@ static int tegra_pcie_phy_disable(struct
 	/* override IDDQ */
 	value = pads_readl(pcie, PADS_CTL);
 	value |= PADS_CTL_IDDQ_1L;
-	pads_writel(pcie, PADS_CTL, value);
+	pads_writel(pcie, value, PADS_CTL);
 
 	/* reset PLL */
 	value = pads_readl(pcie, soc->pads_pll_ctl);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/pci-mark-atheros-ar9580-to-avoid-bus-reset.patch queue-4.8/pci-tegra-fix-argument-order-in-tegra_pcie_phy_disable.patch