Patch "platform: don't return 0 from platform_get_irq[_byname]() on error" has been added to the 4.8-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
platform: don't return 0 from platform_get_irq[_byname]() on error
to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
platform-don-t-return-0-from-platform_get_irq-on-error.patch
and it can be found in the queue-4.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e330b9a6bb35dc7097a4f02cb1ae7b6f96df92afMon Sep 17 00:00:00 2001
From: Sergei Shtylyov <[email protected]>
Date: Mon, 4 Jul 2016 01:04:24 +0300
Subject: platform: don't return 0 from platform_get_irq[_byname]() on error
From: Sergei Shtylyov <[email protected]>
commit e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af upstream.
of_irq_get[_byname]() return 0 iff irq_create_of_mapping() call fails. Returning both error code and 0 on failure is a sign of a misdesigned API, it makes the failure check unnecessarily complex and error prone. We should rely on the platform IRQ resource in this case, not return 0, especially as 0 can be a valid IRQ resource too...
--- drivers/base/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/platform.c +2 -2
@@ -97,7 +97,7 @@ int platform_get_irq(struct platform_devint ret; ret =of_irq_get (dev->dev.of_node, num); -if (ret >=0 || ret == -EPROBE_DEFER ) +if (ret >0 || ret == -EPROBE_DEFER )return ret; }
@@ -175,7 +175,7 @@ int platform_get_irq_byname(struct platfint ret; ret =of_irq_get_byname (dev->dev.of_node, name); -if (ret >=0 || ret == -EPROBE_DEFER ) +if (ret >0 || ret == -EPROBE_DEFER )return ret; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.8/platform-don-t-return-0-from-platform_get_irq-on-error.patch