Skip to contentSkip to conversation

Patch "fs/cifs: keep guid when assigning fid to fileinfo" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 26, 2016 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

fs/cifs: keep guid when assigning fid to fileinfo

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
fs-cifs-keep-guid-when-assigning-fid-to-fileinfo.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 94f873717571c759b7928399cbbddfa3d569bd01 Mon Sep 17 00:00:00 2001

From: Aurelien Aptel <[email protected]>
Date: Thu, 22 Sep 2016 07:38:50 +0200
Subject: fs/cifs: keep guid when assigning fid to fileinfo

From: Aurelien Aptel <[email protected]>

commit 94f873717571c759b7928399cbbddfa3d569bd01 upstream.

When we open a durable handle we give a Globally Unique Identifier (GUID) to the server which we must keep for later reference e.g. when reopening persistent handles on reconnection.

Without this the GUID generated for a new persistent handle was lost and 16 zero bytes were used instead on re-opening.

---
 fs/cifs/smb2ops.c |    1 +
 1 file changed, 1 insertion(+)
fs/cifs/smb2ops.c +1 -0
@@ -536,6 +536,7 @@ smb2_set_fid(struct cifsFileInfo *cfile,
 	server->ops->set_oplock_level(cinode, oplock, fid->epoch,
 				      &fid->purge_cache);
 	cinode->can_cache_brlcks = CIFS_CACHE_WRITE(cinode);
+	memcpy(cfile->fid.create_guid, fid->create_guid, 16);
 }
 
 static void

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/fix-regression-which-breaks-dfs-mounting.patch queue-4.4/smb3-guids-should-be-constructed-as-random-but-valid-uuids.patch queue-4.4/clarify-locking-of-cifs-file-and-tcon-structures-and-make-more-granular.patch queue-4.4/fs-cifs-keep-guid-when-assigning-fid-to-fileinfo.patch