Skip to contentSkip to conversation

apache2: cve-2016-5387

PATCH New Joe Slater 1 participant 1 message Oct 27, 2016

lore
Share & tools
lore

Joe Slater

author
#0 lore raw

PATCH 1/1 apache2: cve-2016-5387

Handle HTTP_PROXY envirnoment variable.

---
 .../apache2/apache2/cve-2016-5387.patch            |   25 ++++++++++++++++++++
 .../recipes-httpd/apache2/apache2_2.4.23.bb        |    1 +
 2 files changed, 26 insertions(+)
 create mode 100644 meta-webserver/recipes-httpd/apache2/apache2/cve-2016-5387.patch
meta-webserver/recipes-httpd/apache2/apache2/cve-2016-5387.patch new file +25 -0
new file mode 100644
index 0000000..dbcdfc6
@@ -0,0 +1,25 @@
+This patch has been copied from https://www.apache.org/security/asf-httpoxy-response.txt
+as a mitigation of CVE-2016-5387.
+
+Upstream-Status: Backport - fixed in 2.4.24
+
+Signed-off-by: Joe Slater<[email protected]>
+
+
+--- a/server/util_script.c	(revision 1752426)
++++ b/server/util_script.c	(working copy)
+@@ -186,6 +186,14 @@ AP_DECLARE(void) ap_add_common_vars(request_rec *r
+         else if (!strcasecmp(hdrs[i].key, "Content-length")) {
+             apr_table_addn(e, "CONTENT_LENGTH", hdrs[i].val);
+         }
++        /* HTTP_PROXY collides with a popular envvar used to configure
++         * proxies, don't let clients set/override it.  But, if you must...
++         */
++#ifndef SECURITY_HOLE_PASS_PROXY
++        else if (!strcasecmp(hdrs[i].key, "Proxy")) {
++            ;
++        }
++#endif
+         /*
+          * You really don't want to disable this check, since it leaves you
+          * wide open to CGIs stealing passwords and people viewing them
meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb +1 -0
index be24998..7656595 100644
@@ -17,6 +17,7 @@ SRC_URI = "http://www.apache.org/dist/httpd/httpd-${PV}.tar.bz2 \
            file://httpd-2.4.3-fix-race-issue-of-dir-install.patch \
            file://0001-configure-use-pkg-config-for-PCRE-detection.patch \
            file://configure-allow-to-disable-selinux-support.patch \
+           file://cve-2016-5387.patch \
            file://init \
            file://apache2-volatile.conf \
            file://apache2.service \
Signature · 1 line
1.7.9.5