Patch "drm/prime: Pass the right module owner through to dma_buf_export()" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
drm/prime: Pass the right module owner through to dma_buf_export()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-prime-pass-the-right-module-owner-through-to-dma_buf_export.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
56a76c0123d6cb034975901c80fce2627338ef9eMon Sep 17 00:00:00 2001
From: Chris Wilson <[email protected]>
Date: Wed, 5 Oct 2016 13:21:43 +0100
Subject: drm/prime: Pass the right module owner through to dma_buf_export()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Chris Wilson <[email protected]>
commit 56a76c0123d6cb034975901c80fce2627338ef9e upstream.
dma_buf_export() adds a reference to the owning module to the dmabuf (to prevent the driver from being unloaded whilst a third party still refers to the dmabuf). However, drm_gem_prime_export() was passing its own THIS_MODULE (i.e. drm.ko) rather than the driver. Extract the right owner from the device->fops instead.
v2: Use C99 initializers to zero out unset elements of dma_buf_export_info
v3: Extract the right module from dev->fops.
Testcase: igt/vgem_basic/unload
--- drivers/gpu/drm/drm_prime.c | 17 ++++++++++------- include/drm/drmP.h | 3 ++- 2 files changed, 12 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_prime.c +10 -7
@@ -339,14 +339,17 @@ static const struct dma_buf_ops drm_gem_* using the PRIME helpers. */ struct dma_buf *drm_gem_prime_export (struct drm_device *dev, -struct drm_gem_object *obj,int flags) +struct drm_gem_object *obj, +int flags) { -DEFINE_DMA_BUF_EXPORT_INFO (exp_info); - - exp_info.ops = &drm_gem_prime_dmabuf_ops; - exp_info.size = obj->size; - exp_info.flags = flags; - exp_info.priv = obj; +struct dma_buf_export_info exp_info = { + .exp_name =KBUILD_MODNAME ,/* white lie for debug */ + .owner = dev->driver->fops->owner, + .ops = &drm_gem_prime_dmabuf_ops, + .size = obj->size, + .flags = flags, + .priv = obj, + };if (dev->driver->gem_prime_res_obj) exp_info.resv = dev->driver->gem_prime_res_obj (obj);
include/drm/drmP.h +2 -1
@@ -1029,7 +1029,8 @@ static inline int drm_debugfs_remove_fil#endif extern struct dma_buf *drm_gem_prime_export (struct drm_device *dev, -struct drm_gem_object *obj,int flags); +struct drm_gem_object *obj, +int flags);extern int drm_gem_prime_handle_to_fd (struct drm_device *dev,struct drm_file *file_priv,uint32_t handle,uint32_t flags,int *prime_fd);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/drm-prime-pass-the-right-module-owner-through-to-dma_buf_export.patch