Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/i915/gen9: Drop invalid WARN() during data rate" failed to apply to 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 28, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.8-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 43aa7e87507f519b0b2497b6fac1e894554eaef2 Mon Sep 17 00:00:00 2001

From: Matt Roper <[email protected]>
Date: Fri, 17 Jun 2016 13:42:20 -0700
Subject: [PATCH] drm/i915/gen9: Drop invalid WARN() during data rate
calculation

It's possible to have a non-zero plane mask and still wind up with a total data rate of zero. There are two cases where this can happen:

* planes are active (from the KMS point of view), but are all fully clipped (positioned offscreen)
* the only active plane on a CRTC is the cursor (which is handled independently and not counted into the general data rate computations

These are both valid display setups (although unusual), so we need to drop the WARN().

Testcase: kms_universal_planes.cursor-only-pipe-*

drivers/gpu/drm/i915/intel_pm.c +0 -2
index d74c26f1cf77..8a6751e14ab9 100644
@@ -3115,8 +3115,6 @@ skl_get_total_relative_data_rate(struct intel_crtc_state *intel_cstate)
 		total_data_rate += intel_cstate->wm.skl.plane_y_data_rate[id];
 	}
 
-	WARN_ON(cstate->plane_mask && total_data_rate == 0);
-
 	return total_data_rate;
 }