Skip to contentSkip to conversation

Patch "crypto: marvell - Update transformation context for each dequeued req" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 28, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: marvell - Update transformation context for each dequeued req

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-marvell-update-transformation-context-for-each-dequeued-req.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 09951d83fc58a6f772de09c08e370f6d9970dbb6 Mon Sep 17 00:00:00 2001

From: Romain Perier <[email protected]>
Date: Tue, 9 Aug 2016 11:03:18 +0200
Subject: crypto: marvell - Update transformation context for each dequeued req

From: Romain Perier <[email protected]>

commit 09951d83fc58a6f772de09c08e370f6d9970dbb6 upstream.

So far, sub part of mv_cesa_int was responsible of dequeuing complete requests, then call the 'cleanup' operation on these reqs and call the crypto api callback 'complete'. The problem is that the transformation context 'ctx' is retrieved only once before the while loop. Which means that the wrong 'cleanup' operation might be called on the wrong type of cesa requests, it can lead to memory corruptions with this message:

marvell-cesa f1090000.crypto: dma_pool_free cesa_padding, 5a5a5a5a/5a5a5a5a (bad dma)

This commit fixes the issue, by updating the transformation context for each dequeued cesa request.

Fixes commit 85030c5168f1 ("crypto: marvell - Add support for chai...")
---
 drivers/crypto/marvell/cesa.c |    1 +
 1 file changed, 1 insertion(+)
drivers/crypto/marvell/cesa.c +1 -0
@@ -166,6 +166,7 @@ static irqreturn_t mv_cesa_int(int irq,
 			if (!req)
 				break;
 
+			ctx = crypto_tfm_ctx(req->tfm);
 			mv_cesa_complete_req(ctx, req, 0);
 		}
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/crypto-marvell-don-t-overwrite-default-creq-state-during-initialization.patch queue-4.8/crypto-marvell-update-transformation-context-for-each-dequeued-req.patch