Skip to contentSkip to conversation

Patch "clk: core: Force setting the phase delay when no change" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 29, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

clk: core: Force setting the phase delay when no change

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
clk-core-force-setting-the-phase-delay-when-no-change.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3174b0c9a62bb3738b4a2a506b8a075d4430e353 Mon Sep 17 00:00:00 2001

From: Jean-Francois Moine <[email protected]>
Date: Wed, 24 Aug 2016 08:32:51 +0200
Subject: clk: core: Force setting the phase delay when no change

From: Jean-Francois Moine <[email protected]>

commit 3174b0c9a62bb3738b4a2a506b8a075d4430e353 upstream.

This patch reverts commit 023bd7166be0 ("clk: skip unnecessary set_phase if nothing to do"), fixing two problems:

* in some SoCs, the hardware phase delay depends on the rate ratio of the clock and its parent. So, changing this ratio may imply to set new hardware values, even if the logical delay is the same.

* when the delay was the same as previously, an error was returned.

Fixes 023bd7166be0 ("clk: skip unnecessary set_phase if nothing to do")
---
 drivers/clk/clk.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/clk/clk.c +0 -5
@@ -1908,10 +1908,6 @@ int clk_set_phase(struct clk *clk, int d
 
 	clk_prepare_lock();
 
-	/* bail early if nothing to do */
-	if (degrees == clk->core->phase)
-		goto out;
-
 	trace_clk_set_phase(clk->core, degrees);
 
 	if (clk->core->ops->set_phase)
@@ -1922,7 +1918,6 @@ int clk_set_phase(struct clk *clk, int d
 	if (!ret)
 		clk->core->phase = degrees;
 
-out:
 	clk_prepare_unlock();
 
 	return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/clk-core-force-setting-the-phase-delay-when-no-change.patch