Patch "iwlwifi: mvm: bail out if CTDP start operation fails" has been added to the 4.8-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iwlwifi: mvm: bail out if CTDP start operation fails
to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iwlwifi-mvm-bail-out-if-ctdp-start-operation-fails.patch
and it can be found in the queue-4.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
75cfe338b8a6fadaa28879a969047554701a7589Mon Sep 17 00:00:00 2001
From: Luca Coelho <[email protected]>
Date: Wed, 14 Sep 2016 11:54:36 +0300
Subject: iwlwifi: mvm: bail out if CTDP start operation fails
From: Luca Coelho <[email protected]>
commit 75cfe338b8a6fadaa28879a969047554701a7589 upstream.
We were assigning the return value of iwl_mvm_ctdp_command() to a variable, but never checking it. If this command fails, we should not allow the interface up process to proceed, since it is potentially dangerous to ignore thermal management requirements.
--- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/fw.c +4 -1
@@ -1214,9 +1214,12 @@ int iwl_mvm_up(struct iwl_mvm *mvm) }/* TODO: read the budget from BIOS / Platform NVM */ -if (iwl_mvm_is_ctdp_supported (mvm) && mvm->cooling_dev.cur_state >0 ) +if (iwl_mvm_is_ctdp_supported (mvm) && mvm->cooling_dev.cur_state >0 ) { ret =iwl_mvm_ctdp_command (mvm,CTDP_CMD_OPERATION_START , mvm->cooling_dev.cur_state); +if (ret) + goto error; + }#else /* Initialize tx backoffs to the minimal possible */ iwl_mvm_tt_tx_backoff (mvm,0 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.8/iwlwifi-mvm-support-bar-in-reorder-buffer.patch queue-4.8/iwlwifi-mvm-disable-p2p-queue-on-mac-context-release.patch queue-4.8/iwlwifi-mvm-call-a-different-txq_enable-function.patch queue-4.8/iwlwifi-mvm-free-reserved-queue-on-sta-removal.patch queue-4.8/iwlwifi-mvm-fix-pending-frames-tracking-on-tx-resp.patch queue-4.8/iwlwifi-check-for-valid-ethernet-address-provided-by-oem.patch queue-4.8/iwlwifi-mvm-bail-out-if-ctdp-start-operation-fails.patch