Skip to contentSkip to conversation

usb: xhci: cleanup cmd_completion in xhci_virt_device

PATCH In review Lu Baolu 3 participants 5 messages Nov 3, 2016 – Nov 4, 2016

Subsystems (2)
lore
Share & tools
lore

Lu Baolu

author
#0 lore raw

PATCH 1/1 usb: xhci: cleanup cmd_completion in xhci_virt_device

cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is not used any more. This patch removes it.

---
 drivers/usb/host/xhci-mem.c | 1 -
 drivers/usb/host/xhci.h     | 1 -
 2 files changed, 2 deletions(-)
drivers/usb/host/xhci-mem.c +0 -1
index 6afe323..8102a86 100644
@@ -1032,7 +1032,6 @@ int xhci_alloc_virt_device(struct xhci_hcd *xhci, int slot_id,
 		goto fail;
 	dev->num_rings_cached = 0;
 
-	init_completion(&dev->cmd_completion);
 	dev->udev = udev;
 
 	/* Point to output device context in dcbaa. */
drivers/usb/host/xhci.h +0 -1
index f945380..e2b62e0 100644
@@ -997,7 +997,6 @@ struct xhci_virt_device {
 	int				num_rings_cached;
 #define	XHCI_MAX_RINGS_CACHED	31
 	struct xhci_virt_ep		eps[31];
-	struct completion		cmd_completion;
 	u8				fake_port;
 	u8				real_port;
 	struct xhci_interval_bw_table	*bw_table;
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Lu Baolu

cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is

Structure.

Quoted 3 lines

not used any more. This patch removes it.

[...]

MBR, Sergei

#2 lore raw
Quoted 7 lines · Sergei Shtylyov
Quoted 2 lines · Lu Baolu

cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is

Structure.

I'll fix that while applying the patch, no need to resend

-Mathias

author
#3 lore raw

Hi,

Quoted 10 lines · Mathias Nyman
Quoted 7 lines · Sergei Shtylyov
Quoted 2 lines · Lu Baolu

cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is

Structure.

I'll fix that while applying the patch, no need to resend

Thank you.

Best regards,
Lu Baolu

Quoted 4 lines

-Mathias

#4 lore raw
In reply to Lu Baolu
Quoted 10 lines · Lu Baolu

cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is not used any more. This patch removes it.

---
  drivers/usb/host/xhci-mem.c | 1 -
  drivers/usb/host/xhci.h     | 1 -
  2 files changed, 2 deletions(-)

Thanks, I'll apply it.

-Mathias