drm/amdgpu: fix logic error for checking amdgpu_vram_page_split
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix logic error for checking amdgpu_vram_page_split
Change-Id I8b89da005b8c312a13d5df0c7f82a7921410797e
Signed-off-by JimQu <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -2
@@ -1031,8 +1031,8 @@ static void amdgpu_check_arguments(struct amdgpu_device *adev) amdgpu_vm_block_size =9 ; } -if ((amdgpu_vram_page_split !=-1 && amdgpu_vram_page_split <16 ) || - !amdgpu_check_pot_argument (amdgpu_vram_page_split)) { +if (amdgpu_vram_page_split !=-1 && (amdgpu_vram_page_split <16 || + !amdgpu_check_pot_argument (amdgpu_vram_page_split))) {dev_warn (adev->dev,"invalid VRAM page split (%d)\n" , amdgpu_vram_page_split); amdgpu_vram_page_split =1024 ;
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 07.11.2016 um 02:55 schrieb jimqu:
Quoted 2 lines
Change-Id I8b89da005b8c312a13d5df0c7f82a7921410797eSigned-off-by JimQu <[email protected]>
Ops, nice catch. Patch is Reviewed-by: Christian König <[email protected]>.
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_check_arguments(struct amdgpu_device *adev) · line 1038
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-2@@ -1031,8 +1031,8 @@ static void amdgpu_check_arguments(struct amdgpu_device *adev) amdgpu_vm_block_size =9 ; } -if ((amdgpu_vram_page_split !=-1 && amdgpu_vram_page_split <16 ) || - !amdgpu_check_pot_argument (amdgpu_vram_page_split)) { +if (amdgpu_vram_page_split !=-1 && (amdgpu_vram_page_split <16 || + !amdgpu_check_pot_argument (amdgpu_vram_page_split))) {dev_warn (adev->dev,"invalid VRAM page split (%d)\n" , amdgpu_vram_page_split); amdgpu_vram_page_split =1024 ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx