patch "staging: sm750fb: Fix bugs introduced by early commits" added to staging-linus
This is a note to let you know that I've just added the patch titled
staging: sm750fb: Fix bugs introduced by early commits
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
33c027ae3cfd8fefb6cccccc5c6b2c07d80891ceMon Sep 17 00:00:00 2001
From: Huacai Chen <[email protected]>
Date: Thu, 3 Nov 2016 12:48:43 +0800
Subject: staging: sm750fb: Fix bugs introduced by early commits
Early commit 30ca5cb63c56965 ("staging: sm750fb: change definition of PANEL_PLANE_TL fields") and 27b047bbe1ee9c0 ("staging: sm750fb: change definition of PANEL_PLANE_BR fields") modify the register bit fields definitions. But the modifications are wrong, because the bit mask of "bit field 10:0" is not 0xeff, but 0x7ff. The wrong definition bugs makes display very strange.
--- drivers/staging/sm750fb/ddk750_reg.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_reg.h +4 -4
@@ -601,13 +601,13 @@#define PANEL_PLANE_TL 0x08001C#define PANEL_PLANE_TL_TOP_SHIFT 16 -#define PANEL_PLANE_TL_TOP_MASK (0xeff << 16) -#define PANEL_PLANE_TL_LEFT_MASK 0xeff +#define PANEL_PLANE_TL_TOP_MASK (0x7ff << 16) +#define PANEL_PLANE_TL_LEFT_MASK 0x7ff#define PANEL_PLANE_BR 0x080020#define PANEL_PLANE_BR_BOTTOM_SHIFT 16 -#define PANEL_PLANE_BR_BOTTOM_MASK (0xeff << 16) -#define PANEL_PLANE_BR_RIGHT_MASK 0xeff +#define PANEL_PLANE_BR_BOTTOM_MASK (0x7ff << 16) +#define PANEL_PLANE_BR_RIGHT_MASK 0x7ff#define PANEL_HORIZONTAL_TOTAL 0x080024#define PANEL_HORIZONTAL_TOTAL_TOTAL_SHIFT 16
Signature · 1 line
2.10.2